fix for 1373, where bounds doesn't get updated after a mapController … #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
If you're happy with this, I'll just approve it. Or I can test it tomorrow (but I haven't been keeping up with the conversation). |
|
Give it a day anyway, in case someone spots a flaw. |
|
@ibrierley You happy for this to be merged? |
|
Yes, lets update I guess, and fix if anyone screams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1373
I think setState gets called, but the onPositionChanged gets called before _bounds is updated (inside build). I've also added an extra check for a valid bounds check to be called on a test new bounds (we don't want to update _bounds if the new position is erm out of bounds).