Fix ignore details.scale = 0 to prevent Unsupported operation: Infinity or NaN toInt #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay @urusai88. We'll get round to reviewing this as it comes closer to a time for another release. Thanks for your contribution, we really appreciate it! |
JaffaKetchup
approved these changes
Nov 19, 2022
|
Thanks for your contribution! |
7h30n3
added a commit
to OPENER-next/OpenStop
that referenced
this pull request
Nov 28, 2022
For more details see: fleaflet/flutter_map#1388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I found a bug while you trying to scale map with enabled scaffold drawer. If youll try to zoom a map when one of your finger stays on drawer gesture hook, ScaleUpdateDetails with come with ScaleUpdateDetails.scale = 0, and _getZoomForScale will return infinity zoom
You can try to make this moves on example app or just check the video
Screenrecorder-2022-10-18-19-10-15-11.1.mp4