Add secondary tap to MapOptions #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1444
I've added a property
onSecondaryTaptoMapOptionswhich is usually associated to the right-click action. To implement this behavior I had to remove the dependency to the package positioned_tap_detector_2 which I've re-implemented directly inside flutter_map as it seems like this package is not maintained anymore.You can try the gesture in the example app. I've tested it on MacOS but didn't try on windows or linux but I trust that Flutter is able to recognize the right-click action on those platforms.
P.S: I had to re-generate the platform sources for the project to compile hence why there is changes for the android, ios, web and macos folders in
example;