Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TileLayer Reimplementation (& v4 Release Preparation) #1475

Merged
merged 54 commits into from
May 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
2a04130
Remove broken updateInterval option
rorystephenson Mar 20, 2023
f7ad9b1
Remove Level since it had become a wrapper for CustomPoint
rorystephenson Mar 21, 2023
794a800
Tile layer cleanup and simplification
rorystephenson Mar 21, 2023
306ab79
TileRange and TileBounds abstractions implemented
rorystephenson Mar 23, 2023
f9d46b7
Working with all example app CRSes
rorystephenson Mar 28, 2023
5207fe9
Remove unnecessary _tileZoom and clean up some variables
rorystephenson Mar 28, 2023
a40d5ed
Make TileImage a ChangeNotifier
rorystephenson Mar 28, 2023
0a02907
Rename TileManager to TileImageManager
rorystephenson Mar 28, 2023
866d24c
Add TileUpdateTransformer to tile layer options
rorystephenson Mar 29, 2023
49b5e84
Avoid notifying listeners once a tile has been disposed
rorystephenson Mar 29, 2023
8a687df
Remove note about maybe needing to enable super mixins
rorystephenson Mar 29, 2023
7105833
Remove TileCoordinate export. I don't see why it would be needed outs…
rorystephenson Mar 29, 2023
dfe53cb
Revert changes which were no longer needed
rorystephenson Mar 29, 2023
96969e4
Ignore Podfile in example since it gets generated when running the app
rorystephenson Mar 29, 2023
898eb1c
Add tile scale calculations to the cache
rorystephenson Mar 31, 2023
eda494a
Create missing TileImages during build
rorystephenson Mar 31, 2023
64350c7
Remove TilesContainer option since wrapping the TileLayer with the de…
rorystephenson Apr 2, 2023
716b165
Remove TilesContainer option since wrapping the TileLayer with the de…
rorystephenson Apr 2, 2023
e0a6a0c
Export TileCoordinate
rorystephenson Apr 2, 2023
86ff9e8
Rename TileCoordinate to TileCoordinates
rorystephenson Apr 3, 2023
664d001
Add tileOpacity option
rorystephenson Apr 3, 2023
dadab12
Add an example TileUpdateTransformer
rorystephenson Apr 4, 2023
8e50027
Updated CHANGELOG and versioning throughout
JaffaKetchup Apr 4, 2023
e3a1f22
Avoid reloading images when opacity changes
rorystephenson Apr 4, 2023
f8624b7
Combine opacity/fastReplace/tileFadeIn with a single tileDisplay option
rorystephenson Apr 4, 2023
fbf782c
Privatized `TileDisplay` extender's constructors
JaffaKetchup Apr 4, 2023
601e6a5
Unified `TileDisplay`'s `.map` and `.when` methods
JaffaKetchup Apr 4, 2023
ad78558
Simplified `TileProvider._getTileUrl` method
JaffaKetchup Apr 4, 2023
e88d600
Make default TileUpdateTransformer ignore taps
rorystephenson Apr 4, 2023
64d2007
Add a throttling tile update transformer
rorystephenson Apr 4, 2023
6fbd8f7
Remove overrideTilesWhenUrlChanges option
rorystephenson Apr 5, 2023
3b92616
Merge remote-tracking branch 'upstream/master' into optimise-tile-loa…
JaffaKetchup Apr 11, 2023
543b641
Updated CHANGELOG
JaffaKetchup Apr 11, 2023
05a8d00
Merge remote-tracking branch 'upstream/master' into optimise-tile-loa…
JaffaKetchup Apr 11, 2023
593a592
Applied formatting to 'gestures.dart'
JaffaKetchup Apr 11, 2023
cc4651d
Updated version
JaffaKetchup Apr 11, 2023
8d0b447
Updated CHANGELOG to include #1487
JaffaKetchup Apr 14, 2023
5a14d01
Updated CHANGELOG to include #1495
JaffaKetchup Apr 21, 2023
95a50fd
Merge remote-tracking branch 'upstream/master' into optimise-tile-loa…
JaffaKetchup Apr 21, 2023
8324c0c
Fixed Android build warning in example app
JaffaKetchup Apr 22, 2023
6e06533
Updated GitHub configuration
JaffaKetchup Apr 23, 2023
38561ad
Added example app building to workflow
JaffaKetchup Apr 23, 2023
e3b1eb9
Merged workflow files to enable building of example application
JaffaKetchup Apr 23, 2023
61de792
Attempted fix workflow issues
JaffaKetchup Apr 23, 2023
654db14
Changed incorrect path in workflow
JaffaKetchup Apr 23, 2023
0d10434
Fix tile provider import
rorystephenson Apr 28, 2023
a6d5f96
Remove unnecessary load/prune
rorystephenson Apr 28, 2023
d7a01a7
Formatting
rorystephenson May 1, 2023
c7c16a0
Avoid concurrent modification error when reloading tiles
rorystephenson May 1, 2023
8bb33f0
Include UrlLauncherPlugin registration
rorystephenson May 1, 2023
468c3d0
Prevent map buttons from rotating
rorystephenson May 1, 2023
fa5116a
Remove unnecessary argument
rorystephenson May 1, 2023
84b0029
Tidy up MapEvents
rorystephenson May 1, 2023
a13353f
Add MapEventNonRotatedSizeChange
rorystephenson May 1, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 31 additions & 70 deletions .github/ISSUE_TEMPLATE/bug-report.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,63 +8,55 @@ body:
value: "
# Bug Report

Thanks for taking the time to fill out this bug report! It helps us to improve the experience for you and other developers that may be facing a similar problem. We aim to respond to bug reports as soon as possible, but it may take longer to resolve this issue depending on its complexity and severity. To help us verify the issue quicker, please include as much information as you can.
Thanks for taking the time to fill out this bug report! To help us verify the issue quicker, please include as much information as you can.


---


Before reporting a bug, please:

* Check if there is already an open or closed issue that is similar to yours

* Ensure that you have fully read the documentation (both the website and API docs) that pertains to the function you're having problems with

* Ensure that your Flutter environment is correctly installed & set-up

* Remember that we're volunteers trying our best to help, so please be polite


---
"
- type: markdown
attributes:
value: ---
- type: textarea
id: description
id: details
attributes:
label: What is the bug?
description: What were you implementing when you found this issue? What happens when the bug triggers?
validations:
required: true
- type: textarea
id: expected-behaviour
attributes:
label: What is the expected behaviour?
description: What do you think should have happened?
description: What were you implementing when you found this issue? What happens when the bug triggers? What do you think should have happened instead? Please include as much detail as possible, including screenshots and screen-recordings if you can.
validations:
required: true
- type: textarea
id: reproduce
attributes:
label: How can we reproduce this issue?
label: How can we reproduce it?
description: |
Please include a [minimal reproducible example](https://en.wikipedia.org/wiki/Minimal_reproducible_example) (preferable), otherwise detail the exact steps to reproduce this issue.
If you do not include any information here, it will take longer for us to verify your issue.
placeholder: Text automatically formatted as Dart code, on submission
render: dart
Please include a fully formatted [minimal reproducible example](https://en.wikipedia.org/wiki/Minimal_reproducible_example) wrapped in a [Dart code block](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks#syntax-highlighting), otherwise, detail the exact steps to reproduce this issue.
If you do not include any information here, it will take longer for us to verify your issue.
validations:
required: true
- type: textarea
id: solution
attributes:
label: Do you have a potential solution?
description: "If so, please detail it: it will make it quicker for us to fix the issue"
- type: textarea
id: additional-info
attributes:
label: Can you provide any other information?
description: |
Please attach any other logs, screenshots, or screen recordings.
Is there anything else you'd like to say?
description: "If so, please detail it: it will make it quicker for us to fix the issue."
- type: markdown
attributes:
value: ---
- type: dropdown
- type: input
id: platform
attributes:
label: Platforms Affected
description: What platforms does this issue affect?
multiple: true
options:
- Android
- iOS
- Web
- Windows
- MacOS
- Linux
- Other
label: Platforms
description: Please detail the devices and operating systems you can reproduce this bug on, separated by commas.
placeholder: eg. Android 13 (Samsung Galaxy S99), Windows 11 (x64)
validations:
required: true
- type: dropdown
Expand All @@ -78,35 +70,4 @@ body:
- "Erroneous: Prevents normal functioning and causes errors in the console"
- "Fatal: Causes the application to crash"
validations:
required: true
- type: dropdown
id: frequency
attributes:
label: Frequency
description: How often does this issue occur?
options:
- "Once: Occurred on a single occasion"
- "Rarely: Occurs every so often"
- "Often: Occurs more often than when it doesn't"
- "Consistently: Always occurs at the same time and location"
validations:
required: true
- type: markdown
attributes:
value: ---
- type: checkboxes
id: terms
attributes:
label: Requirements
description: These are in place to prevent spam and unnecessary reports.
options:
- label: I agree to follow this project's [Code of Conduct](https://github.com/fleaflet/flutter_map/blob/master/CODE_OF_CONDUCT.md)
required: true
- label: My Flutter/Dart installation is unaltered, and `flutter doctor` finds no relevant issues
required: true
- label: I am using the [latest stable version](https://pub.dev/packages/flutter_map) of this package
required: true
- label: I have checked the FAQs section on the documentation website
required: true
- label: I have checked for similar issues which may be duplicates
required: true
required: true
13 changes: 5 additions & 8 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
blank_issues_enabled: false
contact_links:
- name: Discord Server
- name: Get Help
url: https://discord.gg/egEGeByf4q
about: Need more generalised help, or just want to talk? Join the Discord server!
- name: Common Issues
url: https://docs.fleaflet.dev/usage/common-issues
about: Check whether your issue is listed as a common issue in the documentation
- name: Plugins
url: https://docs.fleaflet.dev/plugins/list
about: If you need help with a plugin, please ask on their issue tracker first
about: Don't quite understand how to implement something, or just want to talk? Join the Discord server!
- name: Documentation
url: https://docs.fleaflet.dev/
about: Before posting an issue, please ensure you read the documentation thoroughly
62 changes: 21 additions & 41 deletions .github/ISSUE_TEMPLATE/feature-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,24 @@ body:
value: "
# Feature Request

Thanks for taking the time to let us know what you want to see! It helps us to improve the experience for you and other developers that may be facing a similar problem. Unfortunately, response times for feature requests are longer than bug reports, as they are lower priority. If you want this functionality implemented quickly, please make a Pull Request to go alongside this feature request.
Thanks for taking the time to let us know what you want to see!
Unfortunately, response times for feature requests are longer than bug reports, as they are lower priority. If you want this functionality implemented quickly, please make a Pull Request to go alongside this feature request.


---


Before requesting a feature, please:

* Check if there is already an open or closed issue that is similar to yours

* Ensure that you're using the latest version of flutter_map

* Ensure that you've read the documentation (both the website and API docs) thoroughly


---
"
- type: markdown
attributes:
value: ---
- type: textarea
id: description
attributes:
Expand All @@ -25,32 +38,14 @@ body:
attributes:
label: What other alternatives are available?
description: Have you used any workarounds, for example?
- type: textarea
id: additional-info
attributes:
label: Can you provide any other information?
description: |
Please attach any other logs, screenshots, or screen recordings.
Is there anything else you'd like to say?
- type: markdown
attributes:
value: ---
- type: dropdown
id: platform
- type: textarea
id: additional-info
attributes:
label: Platforms Affected
description: What platforms does this issue affect?
multiple: true
options:
- Android
- iOS
- Web
- Windows
- MacOS
- Linux
- Other
validations:
required: true
label: Can you provide any other information?
description: Is there anything else you'd like to say?
- type: dropdown
id: severity
attributes:
Expand All @@ -62,18 +57,3 @@ body:
- "Obtrusive: No workarounds are available, and this is essential to me"
validations:
required: true
- type: markdown
attributes:
value: ---
- type: checkboxes
id: terms
attributes:
label: Requirements
description: These are in place to prevent spam and unnecessary reports.
options:
- label: I agree to follow this project's [Code of Conduct](https://github.com/fleaflet/flutter_map/blob/master/CODE_OF_CONDUCT.md)
required: true
- label: I am using the [latest stable version](https://pub.dev/packages/flutter_map) of this package
required: true
- label: I have checked for similar feature requests which may be duplicates
required: true
119 changes: 0 additions & 119 deletions .github/workflows/flutter.yml

This file was deleted.

Loading