Support Flutter 3.10 (& Rework Tile Providers) #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworked tile provider implementations to improve performance and meet guidelines Removed 'Delete Old Runs' workflow to prevent deletion of built artifacts
JaffaKetchup
changed the title
Updated example app's 'build.gradle'
TesteurManiak
requested changes
May 11, 2023
lib/src/layer/tile_layer/tile_provider/file_providers/tile_provider_html.dart
Outdated
Show resolved
Hide resolved
lib/src/layer/tile_layer/tile_provider/network_image_provider.dart
Outdated
Show resolved
Hide resolved
Removed fallback to `NetworkTileProvider` when `FileTileProvider` used on web
JaffaKetchup
changed the title
|
Checks won't be 100% successful: see axel-op/dart-package-analyzer#23. However, if everything is building, it can be bypassed. |
Merged
JaffaKetchup
pushed a commit
that referenced
this pull request
May 15, 2023
#1512 (5fb3b3b) bumped the minimum Flutter SDK to 3.10, but did not change the minimum Dart SDK. This PR changes the Dart SDK to 3.0 minimum, enabling the new features and performance benefits. In addition, this PR: * Removes the Tuple dependency in favour of Records * Uses new pattern matching switches in some locations * Seals the `TileDisplay` class to benefit from new pattern matching switches, instead of switching on `runtimeType` * Deprecates `TileUpdateTransformers.alwaysLoadAndPrune`, as it should be unnecessary compared to `ignoreTapEvents` * Improves some documentation * Includes some other more minor improvements/changes This PR also fixes the failing Android builds by upgrading Gradle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart fixHttpOverrides/zoning strategiesNetworkTileProviderwhenFileTileProviderused on webIncludes breaking changes.