Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive toolbar layout #274

Open
jacquetc opened this issue Feb 9, 2024 · 2 comments
Open

Responsive toolbar layout #274

jacquetc opened this issue Feb 9, 2024 · 2 comments
Labels
enhancement New feature or request toolbar Issue related to FleatherToolbar

Comments

@jacquetc
Copy link
Contributor

jacquetc commented Feb 9, 2024

Is your feature request related to a problem? Please describe.
Take your example app, resize it to be smaller than the width of the toolbar. Right-most buttons are hidden.

Describe the solution you'd like
See below, I prefer the first solution.

Describe alternatives you've considered
Different solutions:

  • when the container width is smaller than the toolbar width, one drop down menu appears at the right to hold hidden buttons.
  • the buttons can flow below, like in a second, third toolbar
  • enable horizontal scrolling with ScrollView and arrows left and right to scroll manually for non-touch devices. I think this would be the solution adopted by the developer choosing Fleather since you can wrap the Toolbar without touching its internal.
jacquetc added a commit to jacquetc/fleather that referenced this issue Feb 9, 2024
jacquetc added a commit to jacquetc/fleather that referenced this issue Feb 11, 2024
@Aggie85
Copy link

Aggie85 commented Feb 13, 2024

To be honest, it would be nice if there was a layout property and its choices were: scroll, wrap, moreMenu, etc...

Since I stared my Flutter app a little over a year ago and learning along the way, I am learning to be adaptive and creative in ways I was never forced before while programming in Windows for 30+ years.

Flutter's cross-platform ability is very unrestrictive and thinking outside the box as opposed to being constrained by it like a lot of other frameworks is refreshing.

So allowing more options would be better.

Thanks for everyone's work!

All the best,

Aggie85

@jacquetc
Copy link
Contributor Author

Hello,

I'm not a developer of Feather, just a curious tourist doing sand castles, so the following is only my opinion:

As a developer yourself, you already understand that the multiplicity of options impacts the maintainability.

I think that the developers times can be better used to missing core components before creating a more complex front-end. Also, at this stage of development of Fleather, front end can be easily impacted by profound changes in the back-end.

I'm not saying here to not do something. I personally like your idea of options. There is already a FleatherToolbar.basic() factory, there can be others like FleatherToolbar.scroll(), etc...

Actually, you made me thinking on the problem and I see different avenues to choose:

  • Minimal maintenance: offer only the button widgets corresponding to each function. No toolbar, let the developer using Fleather bake whatever toolbar he wants.
  • Widgets + basic toolbar with one basic responsive design. If a developer isn't happy with stock toolbar, he can bake its own with the offered widgets.
  • Higher-level, higher-maintenance toolbars. Several toolbar styles as discussed before.

What do you think ?

If you want to share more of your point of view, a little debate is occurring in this PR: #277

@amantoux amantoux added enhancement New feature or request toolbar Issue related to FleatherToolbar labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request toolbar Issue related to FleatherToolbar
Projects
None yet
Development

No branches or pull requests

3 participants