Skip to content

Commit

Permalink
chore: 🤖 Extend none zero exit for sites deploy failures (#67)
Browse files Browse the repository at this point in the history
## Why?

Extend none zero exit for sites deploy failures

## How?

N/A

## Tickets?

-
[PLAT-1738](https://linear.app/fleekxyz/issue/PLAT-1738/on-deployment-failure-return-non-zero)

## Contribution checklist?

- [x] The commit messages are detailed
- [x] The `build` command runs locally
- [ ] Assets or static content are linked and stored in the project
- [ ] You have manually tested
- [ ] You have provided tests

## Security checklist?

- [ ] Sensitive data has been identified and is being protected properly
- [ ] Injection has been prevented (parameterized queries, no eval or
system calls)

## Preview?

Optionally, provide the preview url here
  • Loading branch information
heldrida authored Nov 6, 2024
1 parent 7eab654 commit 12fa0be
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changeset/two-nails-knock.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@fleek-platform/cli": minor
---

Extend none zero exit for sites deploy failures
3 changes: 1 addition & 2 deletions src/commands/sites/deploy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ const deployAction: SdkGuardedFunction<DeployActionArgs> = async ({
if (!root) {
output.error(t('somethingWrongDurUpload'));
output.printNewLine();

return;
process.exit(1);
}

output.spinner(t('startingSiteDeployment'));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ export const waitUntilDeploymentFinishedAndInformUser = async ({
if (deploymentStatus === 'RELEASE_FAILED') {
output.error(t('deployNotFinishTryAgain'));
output.printNewLine();

return;
process.exit(1);
}

output.success(`${t('deployed')}!`);
Expand Down

0 comments on commit 12fa0be

Please sign in to comment.