Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: links page #286

Merged
merged 9 commits into from
Nov 15, 2024
Merged

feat: links page #286

merged 9 commits into from
Nov 15, 2024

Conversation

csosamorales
Copy link
Contributor

Why?

Clear and short explanation here.

How?

  • Done A (replace with a breakdown of the steps)
  • Done B
  • Done C

Tickets?

Contribution checklist?

  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content are linked and stored in the project
  • Document filename is named after the slug
  • You've reviewed spelling using a grammar checker
  • For documentation, guides or references, you've tested the commands and steps
  • You've done enough research before writing

Security checklist?

  • Sensitive data has been identified and is being protected properly
  • Injection has been prevented (parameterized queries, no eval or system calls)
  • The Components are escaping output (to prevent XSS)

References?

Optionally, provide references such as links

Preview?

Optionally, provide the preview url here

Copy link

changeset-bot bot commented Nov 4, 2024

⚠️ No Changeset found

Latest commit: 72e69be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@csosamorales csosamorales changed the title Feat/links page feat: links page Nov 4, 2024
bcamarneiro
bcamarneiro previously approved these changes Nov 13, 2024
Copy link
Member

@heldrida heldrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s do our best to summarize the PR's by completing the form, making it easier for our teammates to switch context and provide meaningful feedback. Thanks!

README.md Show resolved Hide resolved
src/components/BiweeklySubscription.tsx Outdated Show resolved Hide resolved
src/pages/links.astro Outdated Show resolved Hide resolved
angarita-dev
angarita-dev previously approved these changes Nov 14, 2024
@angarita-dev
Copy link
Contributor

Approved @bcamarneiro I would say lets just check if the spell checker is breaking with this changes or if there's any action required there

Co-authored-by: Camila Sosa Morales <camisosa@fleek.co>
@csosamorales csosamorales merged commit e106a60 into develop Nov 15, 2024
4 of 5 checks passed
@csosamorales csosamorales deleted the feat/links-page branch November 15, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants