Upcoming activities: Add MDM commands

[noahtalerman]

Goal

User story
As an endpoint operator on the Host details page,
I want to see a list of the upcoming MDM commands and scripts
so that I know what upcoming commands/scripts will run on a specific host.

Objective

Mission critical MDM replacement

Original requests

• View past and upcoming MDM commands for a host #20712

Changes

Product

• @noahtalerman: Solve this bug. Context is in the bug here: macOS host not shown as unlocked in the UI after entering unlock PIN #23624 (comment)
• UI changes: Figma link
• REST API changes: Figma link & API docs: upcoming activities - mdm commands #16872
• Permissions changes:
  • Admins, maintainers, and observers can see all activity for hosts that they have access to.
  • A user w/ access to specific teams (not global) can only see activity for hosts assigned to this users team(s). If they hit GET /hosts/:id/activities or GET /hosts/:id/activities/upcoming for a host that they don't have access to, they'll get a forbidden response (403) with this error message: Error: You don’t have permission to view activities. The host belongs to a team you don’t have permissions to view.
• Outdated documentation changes:
  • Add a GET /hosts/:id/activities and GET /hosts/:id/activities/upcoming section in the API for contributors docs. These sections will list all possible activities across all platforms and link to example usage in the REST API docs.
  • In the GET /hosts/:id/activities and GET /hosts/:id/activities/upcoming REST API docs link to the full list of all possible activities in contributor docs.
  • In the release article (or maybe it's own article) describe the first-in-first-out for scripts and MDM commands.
• Changes to paid features or tiers: Available in Fleet Free and Fleet Premium

Engineering

• Database schema migrations: TODO
• Load testing: TODO
• Now that more MDM commands go through the unified queue, see if we can store/trigger next actions in a better way as discussed here: Unified Queue: trigger next activity when receiving results or enqueing new activity #25607 (comment)

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

Context

• Requestor(s): _________________________

QA

Risk assessment

• Risk level: Low

Manual testing steps

1. Validate MDM & DDM activity shows up in feed.
2. Validate Script activity shows up in feed.
3. Validate API activity
4. Validate loading & error state in UI
5. Test upcoming & past feeds
6. Verify details modal match Figma
7. Test created, deleted, ran, installed...
8. Test macOS, Windows, and Linux

Testing notes

NOTE: New users will be displayed in the activity feed, mdm commands that were run prior to update will show "a user"
Additional note: some of these tasks are already complete. e.g. Script and software installs

Confirmation

1. Engineer (@____): Added comment to user story confirming successful completion of QA.
2. QA (@____): Added comment to user story confirming successful completion of QA.

[noahtalerman]

@georgekarrv heads up, we moved this story to "Settled." I think we can start the spec'ing process while Rachael takes a look at API design.

@rachaelshaw when you get the chance, can you please take a look at the API design in Figma?

Please let us know if y'all have any feedback or questions.

[noahtalerman]

Hey @marko-lisica, heads up that I moved this story and "Fleet-initiated" story (#20712) into the drafting board.

When you get to this story, can you please bring Fleet-initiated designs into this story and close out the Fleet-initiated story (#20712) to simplify things for us? One story for adding MDM commands to the activity feed.

I think let's not worry about breaking up the story until we get to estimation.

[noahtalerman]

Hey @zayhanlon and @Patagonia121 heads up, this user story and the following stories didn't make it into the upcoming engineering sprint because we didn't wrap up designs in time.

• Upcoming activities: Add Fleet initiated MDM commands #20301
• Update activity feed #21681

They're still prioritized. We left it on the drafting board so that it can be pulled into the next engineering sprint.

[noahtalerman]

Hey @marko-lisica @Patagonia121 and @zayhanlon, I pulled this user story and the following user stories off of the drafting board (de-prioritized)

• Upcoming activities: Add Fleet initiated MDM commands #20301
• Update activity feed #21681

We're prioritizing the "Upcoming activities run as listed (one queue) and can be canceled" story (#22866) first. This story, targeted for the next eng sprint (4.60), will simplify the piping (backend) so that we can build future activity feed features faster.

Then, the plan is to prioritize parts (or all) of #15920, #20301, #21681 in following engineering sprints.

[noahtalerman]

Pulled these questions from @mna out of Slack so we don't lose them:

• I thought the upcoming queue would also show MDM commands, but the figma calls out only scripts and installed software/apps ? Did we cut MDM commands from the queue for now? (the ticket still mentions them as part of the queue)
• It appears from the figma UI that fleet-initiated upcoming activities are not cancellable, but it's not called out explicitly in a dev note, is that the case?

My (@noahtalerman) response:

• Re MDM commands, my understanding is that we were going to add them in a follow up story here: Upcoming activities: Add MDM commands #15920
• Re Fleet-initiated commands, I think we want these to also be cancellable. It looks like the Figma is just hiding the hover state for the Fleet-initiated activities.

@marko-lisica, for when you're back in office, please let me know if I'm wrong about the above. Can you please update Figma to clarify that all activities are cancellable?

cc @PezHub

[marko-lisica]

My (@noahtalerman) response:

Re MDM commands, my understanding is that we were going to add them in a follow up story here: #15920
Re Fleet-initiated commands, I think we want these to also be cancellable. It looks like the Figma is just hiding the hover state for the Fleet-initiated activities.

@noahtalerman This is right. Added this to a dev note.