Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy automations: run script - Gitops #22116

Closed
10 tasks done
sharon-fdm opened this issue Sep 16, 2024 · 2 comments
Closed
10 tasks done

Policy automations: run script - Gitops #22116

sharon-fdm opened this issue Sep 16, 2024 · 2 comments
Assignees
Labels
#g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~sub-task A technical sub-task that is part of a story. (Not QA'd. Not estimated.)
Milestone

Comments

@sharon-fdm
Copy link
Collaborator

sharon-fdm commented Sep 16, 2024

Checklist based on work done in #21826:

  • pkg/spec/gitops.go
  • Add testdata for policy script
  • Update existing testdata YAML files
  • Policies data store ApplyPolicySpecs
  • PolicySpec struct update in server/fleet/policies.go
  • Return script IDs on batch script update so policies can be applied to script IDs (including revising struct)
  • Consume script IDs and publish to policy batch endpoint in fleetctl
  • Update client_scripts to return scripts rather than just an error, and consume downstream accordingly
  • Same as above, with ApplyTeamScripts in client_teams
  • Clear policy automation associations with delted scripts on bulk update
@sharon-fdm sharon-fdm added the :product Product Design department (shows up on 🦢 Drafting board) label Sep 16, 2024
@sharon-fdm sharon-fdm added :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. #g-endpoint-ops Endpoint ops product group ~sub-task A technical sub-task that is part of a story. (Not QA'd. Not estimated.) and removed :product Product Design department (shows up on 🦢 Drafting board) labels Sep 16, 2024
@sharon-fdm sharon-fdm assigned iansltx and unassigned lucasmrod Sep 19, 2024
@iansltx iansltx added this to the 4.58.0-tentative milestone Sep 23, 2024
@iansltx
Copy link
Member

iansltx commented Sep 24, 2024

Software install PR: #21826

rachaelshaw pushed a commit that referenced this issue Oct 2, 2024
…ipts or install software (#22567)

Another bit of documentation for #22116
iansltx added a commit that referenced this issue Oct 4, 2024
#22115, #22116

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

No changes file, as FE changes file covers the entire feature

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [x] Added/updated tests
- [x] If database migrations are included, checked table schema to
confirm autoupdate
- For database migrations:
- [x] Checked schema for all modified table for columns that will
auto-update timestamps during migration.
- [x] Confirmed that updating the timestamps is acceptable, and will not
cause unwanted side effects.
- [x] Ensured the correct collation is explicitly set for character
columns (`COLLATE utf8mb4_unicode_ci`).
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
Co-authored-by: Tim Lee <timlee@fleetdm.com>
iansltx added a commit that referenced this issue Oct 10, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
… for policy automations there (#22818)

#22117 / #17129 / #22116

---------

Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
@fleet-release
Copy link
Contributor

Gitops scripts run,
Like a stream through glass cities,
Fleet's secure, swift, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~sub-task A technical sub-task that is part of a story. (Not QA'd. Not estimated.)
Development

No branches or pull requests

5 participants