Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong text in macOS host activity feed #23621

Closed
rachaelshaw opened this issue Nov 7, 2024 · 2 comments
Closed

Wrong text in macOS host activity feed #23621

rachaelshaw opened this issue Nov 7, 2024 · 2 comments
Assignees
@jahzielv
Labels
bug Something isn't working as documented :demo ~frontend Frontend-related issue. #g-mdm MDM product group :incoming New issue in triage process. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.61.0

Comments

@rachaelshaw
Copy link
Member

Fleet version: SNAPSHOT-1172f88
Web browser and operating system: Chrome 130.0.6723.92 running on macOS

💥  Actual behavior

In the global feed, I see:
Screenshot 2024-11-07 at 11 36 04 AM

On the host detail page for a macOS host, it says "unlocked this host" when it should say "viewed six-digit unlock PIN for this host":

Screenshot 2024-11-07 at 11 35 02 AM

🧑‍💻  Steps to reproduce

  1. Lock a macOS host
  2. View unlock PIN

🕯️ More info (optional)

N/A
@rachaelshaw rachaelshaw added bug Something isn't working as documented ~frontend Frontend-related issue. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. #g-mdm MDM product group :incoming New issue in triage process. labels Nov 7, 2024
@lukeheath lukeheath added the ~released bug This bug was found in a stable release. label Nov 8, 2024
@georgekarrv georgekarrv added this to the 4.61.0-tentative milestone Nov 21, 2024
@jahzielv jahzielv self-assigned this Dec 2, 2024
@jahzielv jahzielv mentioned this issue Dec 2, 2024
Merged
2 tasks
jahzielv added a commit that referenced this issue Dec 2, 2024
@jahzielv
fix: use the correct copy for a macos host (#24292)
2cdead2 
> Related issue: #23621

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
parsimeikoikai pushed a commit to parsimeikoikai/fleet that referenced this issue Dec 3, 2024
@jahzielv @parsimeikoikai
fix: use the correct copy for a macos host (fleetdm#24292)
f2f5209 
> Related issue: fleetdm#23621

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
@PezHub
Copy link
Contributor

PezHub commented Dec 4, 2024

QA Notes:
#24292 (comment)

@fleet-release
Copy link
Contributor

Unlock text that's wrong,
Fixed, clarity now dawns,
Fleet’s journey is prolonged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jahzielv jahzielv

Labels
bug Something isn't working as documented :demo ~frontend Frontend-related issue. #g-mdm MDM product group :incoming New issue in triage process. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.61.0
Development

No branches or pull requests
6 participants
@georgekarrv @lukeheath @rachaelshaw @jahzielv @fleet-release @PezHub