-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub attestation to official Fleet and fleetd
release binaries and images
#23825
Comments
Hey @lukeheath I think we need your help w/ this user story. Do you think you can own Product Designer responsibilities for it? That includes writing the user story, updating the "Product" section, and being the first point of contact for product questions during the engineering sprint. Assuming yes, I assigned you. Please feel free to pass it back to me if you don't have the capacity. |
@noahtalerman No problem. |
Hey @lukeheath just a reminder to write up the user story for this and get it ready for estimation next week. We want to bring this customer promise into the next engineering sprint (last in Q4). Please let me know how I can be helpful moving this one along! |
@lukeheath just giving you another ping! Please let me know how I can be helpful getting this story ready for estimation tomorrow. |
@noahtalerman Thanks! Getting on this now. |
fleetd
release binaries and images
@noahtalerman I've finished designing this story. Would you please take a look and make sure it looks correct? From watching the initial request conversation, it seems to me that the customer is asking that all official Fleet and I'm also removing the |
@lukeheath looks good to me!
Sounds great 👍 |
@sgress454 Do we need to make any revisions to the implementation after trying to use it during the fleetd release? |
Mostly ensuring proper permissions. I'm readying a follow-up PR to do that, add better error-safety, and add attestation to the desktop and osquery binaries as Lucas suggested. |
for #23825 This PR fixes the previous implementation for attesting fleet/fleetctl/orbit binaries, and adds attestation to the fleet desktop and osqueryd artifacts. * correct permissions are added to all jobs * tag removed from `subject-name` when attesting docker image * using `artifacts.json` rather than the `artifacts` step output from goreleaser to determine image digest I'd like to add a separate job verifying the attestations, working on that now but since all attestation steps are marked as `continue-on-error` it can be a follow-on if we don't get it in with this PR.
@noahtalerman @zayhanlon The first phase of attestation is complete: https://github.com/fleetdm/fleet/attestations/4319743 Beginning with 4.62.0, we are adding SLSA attestation to all archives and binaries attached to our releases. Beginning with 4.63.0, we will be extending SLSA attestation to our container images. I will leave this issue open until then, but wanted to give a status update. |
Goal
Key results
Original requests
Context
Changes
Codename
Chain of Integrity and Provenance for Software (CHiPS)
Product
Engineering
fleetd
binaries)QA
Risk assessment
Manual testing steps
Testing notes
Confirmation
The text was updated successfully, but these errors were encountered: