Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet in your calendar configs #17462

Merged
merged 9 commits into from
Mar 13, 2024

Conversation

getvictor
Copy link
Member

@getvictor getvictor commented Mar 7, 2024

Sub-task for #17230

Configuration changes

App configuration:

integrations:
  google_calendar:
    - email: name@service-account.com
      private_key: ***
      domain: fleetdm.com

Team configuration:

integrations:
  google_calendar:
    email: name@service-account.com
    enable_calendar_events: true
    policies:
      - name: My policy
        id: 12
    webhook_url: https://example.com/policy-remediation

Note: Policy is looked up by name when configuration is set. The policy id is set/updated by the server for internal use.

Checklist for submitter

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
  • Added/updated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 80.79470% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 65.57%. Comparing base (b174a47) to head (b794ee9).

❗ Current head b794ee9 differs from pull request most recent head 95f688d. Consider uploading reports for the commit 95f688d to get more accurate results

Files Patch % Lines
server/service/client.go 69.23% 11 Missing and 5 partials ⚠️
ee/server/service/teams.go 84.78% 4 Missing and 3 partials ⚠️
server/datastore/mysql/policies.go 88.88% 2 Missing and 1 partial ⚠️
server/fleet/integrations.go 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           17230-calendar-feature   #17462      +/-   ##
==========================================================
- Coverage                   65.66%   65.57%   -0.10%     
==========================================================
  Files                        1191     1191              
  Lines                      107575   107723     +148     
  Branches                     2563     2563              
==========================================================
- Hits                        70642    70641       -1     
- Misses                      31576    31707     +131     
- Partials                     5357     5375      +18     
Flag Coverage Δ
backend 66.57% <80.79%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@getvictor getvictor changed the base branch from main to 17230-calendar-feature March 7, 2024 22:15
@getvictor getvictor marked this pull request as ready for review March 7, 2024 22:18
@getvictor getvictor requested a review from a team as a code owner March 7, 2024 22:18
@getvictor getvictor force-pushed the victor/17230-calendar-config branch from e252f9a to b794ee9 Compare March 8, 2024 21:12
Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Left some questions/comments.

server/fleet/integrations.go Outdated Show resolved Hide resolved
ee/server/service/teams.go Outdated Show resolved Hide resolved
ee/server/service/teams.go Outdated Show resolved Hide resolved
ee/server/service/teams.go Outdated Show resolved Hide resolved
ee/server/service/teams.go Show resolved Hide resolved
server/service/integration_enterprise_test.go Outdated Show resolved Hide resolved
server/datastore/mysql/policies_test.go Show resolved Hide resolved
@getvictor getvictor marked this pull request as draft March 13, 2024 13:54
@getvictor getvictor marked this pull request as ready for review March 13, 2024 14:58
@getvictor getvictor merged commit 1e0339a into 17230-calendar-feature Mar 13, 2024
11 checks passed
@getvictor getvictor deleted the victor/17230-calendar-config branch March 13, 2024 15:05
getvictor added a commit that referenced this pull request Mar 13, 2024
Sub-task for #17230 

# Configuration changes
App configuration:
```yaml
integrations:
  google_calendar:
    - email: name@service-account.com
      private_key: ***
      domain: fleetdm.com
```
Team configuration:
```yaml
integrations:
  google_calendar:
    email: name@service-account.com
    enable_calendar_events: true
    policies:
      - name: My policy
        id: 12
    webhook_url: https://example.com/policy-remediation
```

Note: Policy is looked up by name when configuration is set. The policy
id is set/updated by the server for internal use.

# Checklist for submitter
<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [ ] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
getvictor added a commit that referenced this pull request Mar 15, 2024
Sub-task for #17230 

# Configuration changes
App configuration:
```yaml
integrations:
  google_calendar:
    - email: name@service-account.com
      private_key: ***
      domain: fleetdm.com
```
Team configuration:
```yaml
integrations:
  google_calendar:
    email: name@service-account.com
    enable_calendar_events: true
    policies:
      - name: My policy
        id: 12
    webhook_url: https://example.com/policy-remediation
```

Note: Policy is looked up by name when configuration is set. The policy
id is set/updated by the server for internal use.

# Checklist for submitter
<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [ ] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
getvictor added a commit that referenced this pull request Mar 19, 2024
Sub-task for #17230 

# Configuration changes
App configuration:
```yaml
integrations:
  google_calendar:
    - email: name@service-account.com
      private_key: ***
      domain: fleetdm.com
```
Team configuration:
```yaml
integrations:
  google_calendar:
    email: name@service-account.com
    enable_calendar_events: true
    policies:
      - name: My policy
        id: 12
    webhook_url: https://example.com/policy-remediation
```

Note: Policy is looked up by name when configuration is set. The policy
id is set/updated by the server for internal use.

# Checklist for submitter
<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [ ] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
getvictor added a commit that referenced this pull request Mar 25, 2024
Sub-task for #17230 

# Configuration changes
App configuration:
```yaml
integrations:
  google_calendar:
    - email: name@service-account.com
      private_key: ***
      domain: fleetdm.com
```
Team configuration:
```yaml
integrations:
  google_calendar:
    email: name@service-account.com
    enable_calendar_events: true
    policies:
      - name: My policy
        id: 12
    webhook_url: https://example.com/policy-remediation
```

Note: Policy is looked up by name when configuration is set. The policy
id is set/updated by the server for internal use.

# Checklist for submitter
<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [ ] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
getvictor added a commit that referenced this pull request Mar 26, 2024
Sub-task for #17230 

# Configuration changes
App configuration:
```yaml
integrations:
  google_calendar:
    - email: name@service-account.com
      private_key: ***
      domain: fleetdm.com
```
Team configuration:
```yaml
integrations:
  google_calendar:
    email: name@service-account.com
    enable_calendar_events: true
    policies:
      - name: My policy
        id: 12
    webhook_url: https://example.com/policy-remediation
```

Note: Policy is looked up by name when configuration is set. The policy
id is set/updated by the server for internal use.

# Checklist for submitter
<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [ ] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants