-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fleet in your calendar configs #17462
Fleet in your calendar configs #17462
Conversation
2766d92
to
7ba97e1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 17230-calendar-feature #17462 +/- ##
==========================================================
- Coverage 65.66% 65.57% -0.10%
==========================================================
Files 1191 1191
Lines 107575 107723 +148
Branches 2563 2563
==========================================================
- Hits 70642 70641 -1
- Misses 31576 31707 +131
- Partials 5357 5375 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e252f9a
to
b794ee9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Left some questions/comments.
Sub-task for #17230 # Configuration changes App configuration: ```yaml integrations: google_calendar: - email: name@service-account.com private_key: *** domain: fleetdm.com ``` Team configuration: ```yaml integrations: google_calendar: email: name@service-account.com enable_calendar_events: true policies: - name: My policy id: 12 webhook_url: https://example.com/policy-remediation ``` Note: Policy is looked up by name when configuration is set. The policy id is set/updated by the server for internal use. # Checklist for submitter <!-- Note that API documentation changes are now addressed by the product design team. --> - [ ] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality
Sub-task for #17230 # Configuration changes App configuration: ```yaml integrations: google_calendar: - email: name@service-account.com private_key: *** domain: fleetdm.com ``` Team configuration: ```yaml integrations: google_calendar: email: name@service-account.com enable_calendar_events: true policies: - name: My policy id: 12 webhook_url: https://example.com/policy-remediation ``` Note: Policy is looked up by name when configuration is set. The policy id is set/updated by the server for internal use. # Checklist for submitter <!-- Note that API documentation changes are now addressed by the product design team. --> - [ ] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality
Sub-task for #17230 # Configuration changes App configuration: ```yaml integrations: google_calendar: - email: name@service-account.com private_key: *** domain: fleetdm.com ``` Team configuration: ```yaml integrations: google_calendar: email: name@service-account.com enable_calendar_events: true policies: - name: My policy id: 12 webhook_url: https://example.com/policy-remediation ``` Note: Policy is looked up by name when configuration is set. The policy id is set/updated by the server for internal use. # Checklist for submitter <!-- Note that API documentation changes are now addressed by the product design team. --> - [ ] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality
Sub-task for #17230 # Configuration changes App configuration: ```yaml integrations: google_calendar: - email: name@service-account.com private_key: *** domain: fleetdm.com ``` Team configuration: ```yaml integrations: google_calendar: email: name@service-account.com enable_calendar_events: true policies: - name: My policy id: 12 webhook_url: https://example.com/policy-remediation ``` Note: Policy is looked up by name when configuration is set. The policy id is set/updated by the server for internal use. # Checklist for submitter <!-- Note that API documentation changes are now addressed by the product design team. --> - [ ] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality
Sub-task for #17230 # Configuration changes App configuration: ```yaml integrations: google_calendar: - email: name@service-account.com private_key: *** domain: fleetdm.com ``` Team configuration: ```yaml integrations: google_calendar: email: name@service-account.com enable_calendar_events: true policies: - name: My policy id: 12 webhook_url: https://example.com/policy-remediation ``` Note: Policy is looked up by name when configuration is set. The policy id is set/updated by the server for internal use. # Checklist for submitter <!-- Note that API documentation changes are now addressed by the product design team. --> - [ ] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality
Sub-task for #17230
Configuration changes
App configuration:
Team configuration:
Note: Policy is looked up by name when configuration is set. The policy id is set/updated by the server for internal use.
Checklist for submitter
changes/
ororbit/changes/
.