Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS updates w/ DDM coming soon! #17969

Merged
merged 3 commits into from
Apr 1, 2024
Merged

OS updates w/ DDM coming soon! #17969

merged 3 commits into from
Apr 1, 2024

Conversation

noahtalerman
Copy link
Member

- In Fleet 4.48, we'll ship ""
- OS updates w/ DDM will ship in 4.49
- Update error message to let user know OS updates w/ DDM are coming soon.
- In the Figma wireframes here for () add designs for new error message copy.
@noahtalerman noahtalerman requested a review from a team as a code owner March 29, 2024 20:46
georgekarrv
georgekarrv previously approved these changes Mar 29, 2024
@noahtalerman
Copy link
Member Author

@georgekarrv, @roperzh, @gillespi314, and @marko-lisica what do you think?

@noahtalerman noahtalerman changed the title Update error message for OS updates declaration profile OS updates w/ DDM coming soon! Mar 29, 2024
@noahtalerman
Copy link
Member Author

Hey @georgekarrv and @lukeheath heads up, I think we want to get these changes merged before we ship.

Fighting w/ some backend tests right now.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.68%. Comparing base (8f1f1b7) to head (7186cd9).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17969      +/-   ##
==========================================
+ Coverage   65.56%   65.68%   +0.11%     
==========================================
  Files        1208     1208              
  Lines      112108   112108              
  Branches     2607     2607              
==========================================
+ Hits        73501    73634     +133     
+ Misses      33009    32891     -118     
+ Partials     5598     5583      -15     
Flag Coverage Δ
backend 66.71% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roperzh roperzh merged commit 3e34c0a into main Apr 1, 2024
22 checks passed
@roperzh roperzh deleted the noahtalerman-patch-9 branch April 1, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants