-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for iOS/iPadOS to osquery-perf #19522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to already have that supported for load tests!
go runAppleIDeviceMDMLoop(i, stats, model, *serverURL, *mdmSCEPChallenge, *mdmCheckInInterval) | ||
time.Sleep(sleepTime) | ||
continue | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if it wouldn't be better for future maintainability to have this iDevice thing part of the agent
as for the other hosts, or maybe create a distinct agent
type and have a constructor function take care of returning the right agent based on the template?
Not a blocker, just that osquery-perf
is already very "loosely organized" and it is a bit tricky to understand and maintain. Maybe for some future work, to refactor some of this (not just iDevice stuff).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, this is on my mind.
I did not go that route because current iteration required us testing for ~100 apple devices and also due to time constraints :). As soon as we require support for a bigger number we should do some refactoring (and factor in the refactor during estimation).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19522 +/- ##
===========================================
- Coverage 69.81% 63.26% -6.55%
===========================================
Files 15 984 +969
Lines 921 120661 +119740
Branches 75 75
===========================================
+ Hits 643 76342 +75699
- Misses 277 38116 +37839
- Partials 1 6203 +6202
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merging as the Docker publish looks unrelated (probably related to the move to Goreleaser 2.0) |
#18119
cmd/osquery-perf
for new osquery data ingestion features.Sample on how to simulate 50 iPads and 50 iPhones: