Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing field in setup confirmation #2005

Merged
merged 4 commits into from
Sep 10, 2021
Merged

Fix missing field in setup confirmation #2005

merged 4 commits into from
Sep 10, 2021

Conversation

gillespi314
Copy link
Contributor

@gillespi314
Copy link
Contributor Author

gillespi314 commented Sep 10, 2021 •
edited
Loading

@zwass
The "Submit" button and "Success" screen are a bit misleading because the POST doesn't happen until the user clicks the "Finish" button. The data displayed on the Success screen is just the local form data that has yet to be posted.

@zwass
Copy link
Member

zwass commented Sep 10, 2021

@gillespi314 what if we make the "submit" button another "next", then title the final screen "confirm" and make the button say "confirm"? If this sounds good, please update and update Figma as well.

zwass
zwass approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@zwass zwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, feel free to make the proposed changes or similar as well.

@gillespi314 gillespi314 merged commit 6a3458f into main Sep 10, 2021
@gillespi314 gillespi314 deleted the 2004-setup-url branch September 10, 2021 23:53
@JoStableford
Copy link
Contributor

Related to a Slack conversation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwass zwass zwass approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fleet URL missing on setup page
3 participants
@gillespi314 @zwass @JoStableford