Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add/remove/disable vpp token in Fleet UI #20127

Merged
merged 16 commits into from
Jul 10, 2024

Conversation

ghernandez345
Copy link
Contributor

@ghernandez345 ghernandez345 commented Jul 1, 2024

relates to #19866

NOTE: API integration work still needs to be done, which will happen in another PR.

This adds the ability to add, remove, or disable a VPP token in the Fleet UI. This includes:

Vpp integration page with VPP card:

image

image

image

VPP setup page with steps to set up VPP:

image

VPP setup page with VPP info:

image

Disable VPP modal:

image

renew Vpp modal:

image

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Manual QA for all new/changed functionality

Copy link
Contributor

@gillespi314 gillespi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some minor questions/comments for your consideration :)

frontend/interfaces/config.ts Show resolved Hide resolved
frontend/pages/admin/IntegrationsPage/cards/Vpp/Vpp.tsx Outdated Show resolved Hide resolved
<p>
Apps purchased in Apple Business Manager won&apos;t appear in Fleet.
Apps won&apos;t be uninstalled from hosts. If you want to enable
integration again, you&apos;ll have to upload a new content token.
Copy link
Contributor

@gillespi314 gillespi314 Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to enable integration again

Is there a word missing here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think so. what bit of work are you thinking?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it should be "If you want to enable VPP integration again..." or "If you want to enable this integration again..." or something like that. Feels like "integration" is just hanging there and needs a modifier to link it to the prior sentence.

Copy link
Contributor Author

@ghernandez345 ghernandez345 Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh sorry. ha, I though this said "work missing here?" yes it does sound a little strange.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, yeah, it did say "work". I edited it when I replied.

Copy link
Contributor Author

@ghernandez345 ghernandez345 Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marko-lisica are you ok to change the copy to say "If you want to enable VPP integration again..." instead of "If you want to enable integration again..."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghernandez345 Sounds good to me. I'll update Figma as well.

@ghernandez345 ghernandez345 merged commit 845b524 into feat-vpp-apps-18867 Jul 10, 2024
5 checks passed
@ghernandez345 ghernandez345 deleted the feat-ui-vpp-token branch July 10, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants