-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add/remove/disable vpp token in Fleet UI #20127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Some minor questions/comments for your consideration :)
frontend/pages/admin/IntegrationsPage/cards/Vpp/VppSetupPage/VppSetupPage.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/admin/IntegrationsPage/cards/Vpp/VppSetupPage/VppSetupPage.tsx
Show resolved
Hide resolved
<p> | ||
Apps purchased in Apple Business Manager won't appear in Fleet. | ||
Apps won't be uninstalled from hosts. If you want to enable | ||
integration again, you'll have to upload a new content token. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to enable integration again
Is there a word missing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think so. what bit of work are you thinking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it should be "If you want to enable VPP integration again..." or "If you want to enable this integration again..." or something like that. Feels like "integration" is just hanging there and needs a modifier to link it to the prior sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohhh sorry. ha, I though this said "work missing here?" yes it does sound a little strange.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol, yeah, it did say "work". I edited it when I replied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marko-lisica are you ok to change the copy to say "If you want to enable VPP integration again..." instead of "If you want to enable integration again..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ghernandez345 Sounds good to me. I'll update Figma as well.
...ges/admin/IntegrationsPage/cards/Vpp/VppSetupPage/components/VppSetupSteps/VppSetupSteps.tsx
Show resolved
Hide resolved
cc31c32
to
2d66479
Compare
37141d4
to
ebd3cb6
Compare
ebd3cb6
to
50ad7eb
Compare
e079345
to
060c728
Compare
relates to #19866
This adds the ability to add, remove, or disable a VPP token in the Fleet UI. This includes:
Vpp integration page with VPP card:
VPP setup page with steps to set up VPP:
VPP setup page with VPP info:
Disable VPP modal:
renew Vpp modal:
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.