feat: backend for VPP related global activities #20484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahzielv
changed the title
|
Note: I'm going to implement the host activities in the branch that Roberto started for the actual installation process. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat-vpp-apps-18867 #20484 +/- ##
======================================================
Coverage ? 37.19%
======================================================
Files ? 1423
Lines ? 134025
Branches ? 3201
======================================================
Hits ? 49849
Misses ? 79662
Partials ? 4514
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jahzielv
requested review from
rachaelshaw,
roperzh,
gillespi314,
lucasmrod,
getvictor and
a team
as code owners
mna
reviewed
Jul 16, 2024
mna
approved these changes
Jul 16, 2024
mna
approved these changes
Jul 16, 2024
|
Merging as the one failing test is unrelated: https://github.com/fleetdm/fleet/actions/runs/9958739248/job/27513841683?pr=20484#step:13:3143 |
roperzh
reviewed
Jul 22, 2024
| return ctxerr.Wrap(ctx, err, "delete VPP token") | ||
| } | ||
|
|
||
| act := fleet.ActivityDisabledVPP{} |
There was a problem hiding this comment.
Have we decided to not store an user id for add/remove here?
| SoftwareTitle string `json:"software_title"` | ||
| AppStoreID string `json:"app_store_id"` | ||
| TeamName *string `json:"team_name"` | ||
| TeamID *uint `json:"team_id"` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.