Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPP: unify List host's software and List my device's software response payload #20519

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

mna
Copy link
Member

@mna mna commented Jul 16, 2024

#19880 part 3 of the ticket

NOTE that this targets #20483, which must be merged first.

Checklist for submitter

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated tests

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 71.87500% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat-vpp-apps-18867@0f9a549). Learn more about missing BASE report.

Files Patch % Lines
server/datastore/mysql/software.go 71.87% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             feat-vpp-apps-18867   #20519   +/-   ##
======================================================
  Coverage                       ?   37.19%           
======================================================
  Files                          ?     1423           
  Lines                          ?   134100           
  Branches                       ?     3198           
======================================================
  Hits                           ?    49883           
  Misses                         ?    79695           
  Partials                       ?     4522           
Flag Coverage Δ
backend 35.77% <71.87%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mna mna marked this pull request as ready for review July 16, 2024 19:43
@mna mna requested a review from a team as a code owner July 16, 2024 19:43
Base automatically changed from mna-19880-list-vpp-apps-2 to feat-vpp-apps-18867 July 16, 2024 20:18
@mna mna force-pushed the mna-19880-list-vpp-apps-3 branch from f2c5f29 to cb1f276 Compare July 16, 2024 20:20
@mna mna merged commit 75bdc05 into feat-vpp-apps-18867 Jul 16, 2024
21 checks passed
@mna mna deleted the mna-19880-list-vpp-apps-3 branch July 16, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants