VPP: fix download package path, implement delete VPP app support #20530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mna
commented
Jul 17, 2024
| @@ -141,6 +141,8 @@ func (ds *Datastore) BatchInsertVPPApps(ctx context.Context, apps []*fleet.VPPAp | |||
|
|
|||
| func (ds *Datastore) InsertVPPAppWithTeam(ctx context.Context, app *fleet.VPPApp, teamID *uint) error { | |||
| return ds.withRetryTxx(ctx, func(tx sqlx.ExtContext) error { | |||
| // TODO: we should not just create a software title, I think we should try | |||
| // to match to an existing one (i.e. getOrCreate logic)? | |||
There was a problem hiding this comment.
Following Slack convo, Sarah will be tackling this change.
There was a problem hiding this comment.
Scratch that, Sarah is not available today, I'll try to tackle this in another PR.
mna
requested review from
roperzh,
gillespi314,
lucasmrod,
getvictor and
a team
as code owners
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20515
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)