rearrange migrations and generate dump #20652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't reviewed, but just FYI we've deployed yesterday's |
thank you! I think we're good 🎉 this is still in the feature branch, and by moving these migrations to the bottom we should be fine for the next time we deploy |
jahzielv
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this re-arranges migrations so the VPP schema changes happen after already merged migrations and commits the result of running
make dump-test-schemausing mysql 8.note that there are a bunch of seemingly unrelated changes in the diff, but that's just the mysql 8 bump, the diff against
mainshould be smaller.