Fleet server now accepts arguments via stdin #21124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmrod
reviewed
Aug 7, 2024
| @@ -0,0 +1,156 @@ | |||
| // Based on https://github.com/kballard/go-shellquote | |||
There was a problem hiding this comment.
Why not use the package? (out of curiosity) Is it because it's not active?
There was a problem hiding this comment.
With all the supply chain attacks, the current trend is to reduce the amount of dependencies for security. The 1 function I needed was pretty small to bring in.
lucasmrod
reviewed
Aug 7, 2024
| } | ||
| } | ||
|
|
||
| var simpleSplitTest = []struct { |
There was a problem hiding this comment.
Nit: While we're at it, add a test for flags like --foo bar or with characters that might be on server private keys like 6mI4OpVBAidu1bALjY0F+wN4mPQyu8AZap/9M/kHp8I=?
lucasmrod
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21038
Fleet server now accepts arguments via stdin. This is useful for passing secrets that you don't want to expose as env vars, in the command line, or in the config file.
Demo: https://www.loom.com/share/c8b4dc6ae6ef4182bc812d7f43423f4d
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)