Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSVPP Backend and CLI #21132

Merged
merged 39 commits into from
Aug 14, 2024
Merged

SSVPP Backend and CLI #21132

merged 39 commits into from
Aug 14, 2024

Conversation

dantecatalfamo
Copy link
Member

@dantecatalfamo dantecatalfamo commented Aug 7, 2024 •
edited
Loading

#19882 and #20532

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated tests
  • If database migrations are included, checked table schema to confirm autoupdate
  • For database migrations:
    • Checked schema for all modified table for columns that will auto-update timestamps during migration.
    • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
    • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).
  • Manual QA for all new/changed functionality

@dantecatalfamo
Got batch associate working
11998ce 
Song: Waterfall
Album: Water
Artist: BICEP
@dantecatalfamo dantecatalfamo changed the title SSVPP Backend SSVPP Backend and CLI Aug 13, 2024
mna
mna previously approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@mna mna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mna
mna previously approved these changes Aug 13, 2024
View reviewed changes
mna
mna approved these changes Aug 13, 2024
View reviewed changes
.github/workflows/test-packaging.yml
# colima -> lima -> qemu -> glibc -> python@3.12
# Force upgrade it for now, remove once the problem is fixed
brew install --overwrite python@3.12
brew install colima
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

roperzh
roperzh approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@roperzh roperzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trusting Martin's review, approving to see if this unblocks codeowners

@dantecatalfamo dantecatalfamo merged commit 9a5e537 into main Aug 14, 2024
18 checks passed
@dantecatalfamo dantecatalfamo deleted the ssvpp-backend branch August 14, 2024 14:25
@dantecatalfamo dantecatalfamo mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mna mna mna approved these changes

@georgekarrv georgekarrv georgekarrv approved these changes

@roperzh roperzh roperzh approved these changes

@eashaw eashaw eashaw approved these changes

@gillespi314 gillespi314 Awaiting requested review from gillespi314

@lucasmrod lucasmrod Awaiting requested review from lucasmrod

@getvictor getvictor Awaiting requested review from getvictor

@lukeheath lukeheath Awaiting requested review from lukeheath lukeheath is a code owner

@sharon-fdm sharon-fdm Awaiting requested review from sharon-fdm sharon-fdm is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dantecatalfamo @mna @georgekarrv @roperzh @eashaw