-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add UI to support self service VPP software #21174
add UI to support self service VPP software #21174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few comment/questions for your consideration :)
frontend/pages/hosts/details/cards/Software/SelfService/SelfService.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/hosts/details/cards/Software/SelfService/SelfServiceItem/SelfServiceItem.tsx
Outdated
Show resolved
Hide resolved
}; | ||
|
||
if (isSelfService) { | ||
postBody.self_service = isSelfService; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, how does the API response if we were to send self_service: false
explicitly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question. it seems to be handled the same way as when its undefined. @dantecatalfamo is this a
correct assumption of how this endpoint will work when we pass self_service: false
explicitly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving doc changes as codeowner. I haven't reviewed frontend changes.
450e51f
to
399a64f
Compare
cca0e69
to
450e51f
Compare
…if VPP is self service
4af3b0a
to
100a0f1
Compare
relates to #19883 implements UI to support self service VPP apps. **Self service checkbox in add software modal** ![image](https://github.com/user-attachments/assets/bb6f3b3b-61aa-4a78-a223-e73ad2c2c5b9) The rest of the changes are the same as the original self service feature. - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Manual QA for all new/changed functionality
relates to #19883
implements UI to support self service VPP apps.
Self service checkbox in add software modal
The rest of the changes are the same as the original self service feature.
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.