add UI to support self service VPP software #21174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghernandez345
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
gillespi314
reviewed
Aug 8, 2024
frontend/pages/hosts/details/cards/Software/SelfService/SelfService.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/hosts/details/cards/Software/SelfService/SelfServiceItem/SelfServiceItem.tsx
Outdated
Show resolved
Hide resolved
| }; | ||
|
|
||
| if (isSelfService) { | ||
| postBody.self_service = isSelfService; |
There was a problem hiding this comment.
Out of curiosity, how does the API response if we were to send self_service: false explicitly?
There was a problem hiding this comment.
good question. it seems to be handled the same way as when its undefined. @dantecatalfamo is this a
correct assumption of how this endpoint will work when we pass self_service: false explicitly?
lukeheath
approved these changes
Aug 8, 2024
ghernandez345
force-pushed
the
feat-ui-self-service-vpp
branch
from
450e51f
to
399a64f
Compare
ghernandez345
requested review from
lucasmrod,
georgekarrv,
sharon-fdm,
Sampfluger88,
mikermcneil,
eashaw,
rfairburn,
ksatter,
edwardsb,
roperzh,
getvictor,
jacobshandling,
mostlikelee and
a team
as code owners
ghernandez345
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
ghernandez345
had a problem deploying
to
Docker Hub
GitHub Actions
Error
ghernandez345
removed request for
a team,
mikermcneil,
georgekarrv,
edwardsb,
lucasmrod,
getvictor and
roperzh
ghernandez345
removed request for
spokanemac,
eashaw,
rfairburn,
mostlikelee,
ksatter,
jacobshandling,
Sampfluger88 and
sharon-fdm
ghernandez345
force-pushed
the
feat-ui-self-service-vpp
branch
from
cca0e69
to
450e51f
Compare
ghernandez345
had a problem deploying
to
Docker Hub
GitHub Actions
Error
ghernandez345
had a problem deploying
to
Docker Hub
GitHub Actions
Error
…if VPP is self service
ghernandez345
force-pushed
the
feat-ui-self-service-vpp
branch
from
4af3b0a
to
100a0f1
Compare
ghernandez345
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
ghernandez345
added a commit
that referenced
this pull request
Aug 20, 2024
relates to #19883 implements UI to support self service VPP apps. **Self service checkbox in add software modal**  The rest of the changes are the same as the original self service feature. - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Manual QA for all new/changed functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #19883
implements UI to support self service VPP apps.
Self service checkbox in add software modal
The rest of the changes are the same as the original self service feature.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.