-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Auto install software (Fleet UI: Updates to software details page) #21194
Feature: Auto install software (Fleet UI: Updates to software details page) #21194
Conversation
d7971fa
to
1b93bf3
Compare
frontend/pages/SoftwarePage/components/SoftwareLastUpdatedInfo/SoftwareLastUpdatedInfo.tsx
Show resolved
Hide resolved
3f71ace
to
e69e052
Compare
frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwareTitleDetailsPage.tsx
Show resolved
Hide resolved
2d57d46
to
c74a62e
Compare
const labels = softwarePackage?.labels_include_any?.length | ||
? softwarePackage.labels_include_any.map((label) => label.name) | ||
: softwarePackage?.labels_exclude_any.map((label) => label.name) || []; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO on subsequent PR: Add newly designed tooltip header https://fleetdm.slack.com/archives/C02A8BRABB5/p1723160752715049?thread_ts=1723059265.568719&cid=C02A8BRABB5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added since I was back in the code
const tooltipLines = softwarePackage?.labels_include_any?.length
? ["Includes any:", ...labels]
: ["Excludes any:", ...labels];
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! A few small requests/questions
@@ -15,7 +17,9 @@ const INSTALL_DETAILS_STATUS_PREDICATES: Record< | |||
string | |||
> = { | |||
pending: "is installing or will install", | |||
installed: "installed", | |||
verified: "verified", // TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there still things TODO for these 3 lines?
@@ -286,7 +292,9 @@ export type IDeviceSoftware = IHostSoftware; | |||
|
|||
const INSTALL_STATUS_PREDICATES: Record<SoftwareInstallStatus, string> = { | |||
failed: "failed to install", | |||
installed: "installed", | |||
verified: "verified?", // TODO: jacob |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋
...tend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwarePackageCard/SoftwarePackageCard.tsx
Outdated
Show resolved
Hide resolved
...tend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwarePackageCard/SoftwarePackageCard.tsx
Show resolved
Hide resolved
...tend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwarePackageCard/SoftwarePackageCard.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/hosts/details/cards/Software/InstallStatusCell/InstallStatusCell.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/hosts/details/cards/Software/InstallStatusCell/InstallStatusCell.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/hosts/details/cards/Software/InstallStatusCell/InstallStatusCell.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/hosts/details/cards/Software/SelfService/SelfServiceItem/SelfServiceItem.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/hosts/details/cards/Software/SelfService/SelfServiceItem/SelfServiceItem.tsx
Outdated
Show resolved
Hide resolved
…r self service page
64f06d8
into
feat-19551-software-auto-install
Issue
Subtask #21048
Story: #19551
Description
Screenrecording 8/8 AM (includes dummy data since API isn't built yet)
https://www.loom.com/share/489a5df0d7df4a51b26a18ff584b988f?sid=f5ed287a-e065-4f21-a0a8-0f1a2330e0ae