Feature: Auto install software (Fleet UI: Updates to software details page) #21194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
RachelElysia
commented
Aug 8, 2024
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
RachelElysia
force-pushed
the
auto-install-details-page
branch
from
d7971fa
to
1b93bf3
Compare
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
RachelElysia
changed the base branch from
main
to
feat-19551-software-auto-install
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
RachelElysia
commented
Aug 9, 2024
frontend/pages/SoftwarePage/components/SoftwareLastUpdatedInfo/SoftwareLastUpdatedInfo.tsx
Show resolved
Hide resolved
RachelElysia
commented
Aug 9, 2024
jacobshandling
force-pushed
the
feat-19551-software-auto-install
branch
from
3f71ace
to
e69e052
Compare
RachelElysia
commented
Aug 9, 2024
frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwareTitleDetailsPage.tsx
Show resolved
Hide resolved
RachelElysia
force-pushed
the
auto-install-details-page
branch
from
2d57d46
to
c74a62e
Compare
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
RachelElysia
commented
Aug 9, 2024
| const labels = softwarePackage?.labels_include_any?.length | ||
| ? softwarePackage.labels_include_any.map((label) => label.name) | ||
| : softwarePackage?.labels_exclude_any.map((label) => label.name) || []; | ||
|
|
There was a problem hiding this comment.
TODO on subsequent PR: Add newly designed tooltip header https://fleetdm.slack.com/archives/C02A8BRABB5/p1723160752715049?thread_ts=1723059265.568719&cid=C02A8BRABB5
There was a problem hiding this comment.
Just added since I was back in the code
const tooltipLines = softwarePackage?.labels_include_any?.length
? ["Includes any:", ...labels]
: ["Excludes any:", ...labels];
jacobshandling
previously requested changes
Aug 9, 2024
| @@ -15,7 +17,9 @@ const INSTALL_DETAILS_STATUS_PREDICATES: Record< | |||
| string | |||
| > = { | |||
| pending: "is installing or will install", | |||
| installed: "installed", | |||
| verified: "verified", // TODO | |||
There was a problem hiding this comment.
are there still things TODO for these 3 lines?
| @@ -286,7 +292,9 @@ export type IDeviceSoftware = IHostSoftware; | |||
|
|
|||
| const INSTALL_STATUS_PREDICATES: Record<SoftwareInstallStatus, string> = { | |||
| failed: "failed to install", | |||
| installed: "installed", | |||
| verified: "verified?", // TODO: jacob | |||
...tend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwarePackageCard/SoftwarePackageCard.tsx
Outdated
Show resolved
Hide resolved
...tend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwarePackageCard/SoftwarePackageCard.tsx
Show resolved
Hide resolved
...tend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwarePackageCard/SoftwarePackageCard.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/hosts/details/cards/Software/InstallStatusCell/InstallStatusCell.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/hosts/details/cards/Software/InstallStatusCell/InstallStatusCell.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/hosts/details/cards/Software/InstallStatusCell/InstallStatusCell.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/hosts/details/cards/Software/SelfService/SelfServiceItem/SelfServiceItem.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/hosts/details/cards/Software/SelfService/SelfServiceItem/SelfServiceItem.tsx
Outdated
Show resolved
Hide resolved
…r self service page
RachelElysia
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
RachelElysia
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
RachelElysia
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
jacobshandling
approved these changes
Aug 13, 2024
RachelElysia
merged commit 64f06d8
into
feat-19551-software-auto-install
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Subtask #21048
Story: #19551
Description
Screenrecording 8/8 AM (includes dummy data since API isn't built yet)
https://www.loom.com/share/489a5df0d7df4a51b26a18ff584b988f?sid=f5ed287a-e065-4f21-a0a8-0f1a2330e0ae