-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added software install capability to agent. #21196
Conversation
cmd/osquery-perf/agent.go
Outdated
|
||
var path string | ||
if !failed { | ||
tmpDir, err := os.MkdirTemp("", "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the loadtest environment we run 500 agents per docker container. They will run out of memory/disk-space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably make the download but not store it anywhere (something like "stream to /dev/null
").
Will consume memory/disk but most likely less.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the change. I still need to download the software once to extract the metadata, and afterwards I can do dummy downloads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Left a couple of questions/comments.
@lucasmrod I checked in fixes. Ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(Let's merge, I can add log.Println
on my PR.)
// Download the file if needed to get its metadata | ||
meta, cacheMiss, err = installerMetadataCache.Get(installer.InstallerID, orbitClient) | ||
if err != nil { | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log.Println
here
Testing feature for #19551