Added software install capability to agent. #21196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmrod
reviewed
Aug 13, 2024
cmd/osquery-perf/agent.go
Outdated
|
|
||
| var path string | ||
| if !failed { | ||
| tmpDir, err := os.MkdirTemp("", "") |
There was a problem hiding this comment.
In the loadtest environment we run 500 agents per docker container. They will run out of memory/disk-space.
There was a problem hiding this comment.
We should probably make the download but not store it anywhere (something like "stream to /dev/null").
Will consume memory/disk but most likely less.
There was a problem hiding this comment.
I made the change. I still need to download the software once to extract the metadata, and afterwards I can do dummy downloads.
lucasmrod
reviewed
Aug 13, 2024
lucasmrod
reviewed
Aug 13, 2024
lucasmrod
reviewed
Aug 13, 2024
@lucasmrod I checked in fixes. Ready for re-review. |
lucasmrod
approved these changes
Aug 21, 2024
| // Download the file if needed to get its metadata | ||
| meta, cacheMiss, err = installerMetadataCache.Get(installer.InstallerID, orbitClient) | ||
| if err != nil { | ||
| return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing feature for #19551