Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Go to 1.22.6 #21201

Merged
merged 2 commits into from
Aug 26, 2024
Merged

update Go to 1.22.6 #21201

merged 2 commits into from
Aug 26, 2024

Conversation

roperzh
Copy link
Member

@roperzh roperzh commented Aug 8, 2024

for #21198

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Manual QA for all new/changed functionality

@roperzh
Copy link
Member Author

roperzh commented Aug 21, 2024

note that go 1.23 is out, but an update will come probably next sprint.

Copy link
Member

@lukeheath lukeheath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Env var updated
image

@roperzh
Copy link
Member Author

roperzh commented Aug 26, 2024

@lucasmrod @getvictor @gillespi314 hey folks, I think I'm only missing a codeowners review from one of you, could you take a look when time allows?

Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'm removing Dockerfile.osquery-perf on a separate PR (looks like it's not used anymore).

@roperzh roperzh merged commit 48e7066 into main Aug 26, 2024
5 checks passed
@roperzh roperzh deleted the 21198-update-go branch August 26, 2024 13:50
roperzh added a commit that referenced this pull request Aug 26, 2024
for #21198

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
roperzh added a commit that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants