Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstall packages #21892

Merged
merged 33 commits into from
Sep 12, 2024
Merged

Uninstall packages #21892

merged 33 commits into from
Sep 12, 2024

Commits on Sep 3, 2024

  1. change file

    Jacob Shandling committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    25d08d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. UI – Implement changes for package uninstall scripts in the add softw… 

    …are modal (#21828)

## Addresses #21564 – see issue for task list
![Screenshot 2024-09-04 at 5 45
12 PM](https://github.com/user-attachments/assets/546401dd-b56e-4c39-baba-456dc844ee0f)
![Screenshot 2024-09-04 at 5 42
57 PM](https://github.com/user-attachments/assets/810ca450-0ddd-4258-96a5-bddb300ae19d)
![Screenshot 2024-09-04 at 5 45
02 PM](https://github.com/user-attachments/assets/32a19ce6-52c3-4772-ba53-00e50145bc85)
![Screenshot 2024-09-04 at 5 43
23 PM](https://github.com/user-attachments/assets/925843fb-6290-489b-a639-de1cbfba83fa)

- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
    @jacobshandling
    jacobshandling and Jacob Shandling authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    0cfbdc6 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Parsing package IDs

    @getvictor
    getvictor committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d7f1329 View commit details
    Browse the repository at this point in the history

  2. Added uninstall script to software_installers

    @getvictor
    getvictor committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ea10d43 View commit details
    Browse the repository at this point in the history

  3. Updated host_software_installs table.

    @getvictor
    getvictor committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5484041 View commit details
    Browse the repository at this point in the history

  4. Fixed schema

    @getvictor
    getvictor committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7e60b64 View commit details
    Browse the repository at this point in the history

  5. Can run install scripts now.

    @getvictor
    getvictor committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    42905d3 View commit details
    Browse the repository at this point in the history

  6. Rebased onto main.

    @getvictor
    getvictor committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    a4a2e40 View commit details
    Browse the repository at this point in the history

  7. Added activity -- core implementation done.

    @getvictor
    getvictor committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5a50e0a View commit details
    Browse the repository at this point in the history

  8. Fixed tests

    @getvictor
    getvictor committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7d47cd9 View commit details
    Browse the repository at this point in the history

  9. Rebase onto main

    @getvictor
    getvictor committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    6f3dc3e View commit details
    Browse the repository at this point in the history

  10. UI - update software title details statuses to reflect possible "unin… 

    …stalling" states (#21858)

## #21565 
![Screenshot 2024-09-05 at 11 57
25 AM](https://github.com/user-attachments/assets/64e3ba67-482b-4e76-9e2f-ebce348bd104)
![Screenshot 2024-09-05 at 11 57
22 AM](https://github.com/user-attachments/assets/97c7ded5-a04d-4aac-bede-a7d65f8614b2)

- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
    @jacobshandling
    jacobshandling and Jacob Shandling authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1095e51 View commit details
    Browse the repository at this point in the history

  11. UI - Help text, link tweaks (#21857) 

    ## Follow-up to #21564 
![Screenshot 2024-09-05 at 11 45
25 AM](https://github.com/user-attachments/assets/3efa3400-d600-4a9c-8488-40f497c6818c)
![Screenshot 2024-09-05 at 11 45
29 AM](https://github.com/user-attachments/assets/5919ba90-970b-4a51-a87d-5ed5226f1337)
![Screenshot 2024-09-05 at 11 45
32 AM](https://github.com/user-attachments/assets/f0ca80fe-fd80-4321-bd2a-8c33aa4c6f25)
![Screenshot 2024-09-05 at 11 45
35 AM](https://github.com/user-attachments/assets/84de54ad-8264-4f5a-a2cc-3aaf8fd3dbe1)

- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
    @jacobshandling
    jacobshandling and Jacob Shandling authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    6d38b3d View commit details
    Browse the repository at this point in the history

  12. Merge branch 'victor/20320-backend' into 20320-ui-uninstall-packages

    Jacob Shandling committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    78c534b View commit details
    Browse the repository at this point in the history

  13. Updated ListHostSoftware test and fixed issues.

    @getvictor
    getvictor committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7951109 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'main' into 20320-feat-uninstall-packages 

    # Conflicts:
#	server/datastore/mysql/schema.sql
    @getvictor
    getvictor committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3f36af9 View commit details
    Browse the repository at this point in the history

  15. Update schema after merge.

    @getvictor
    getvictor committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    026f133 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Fixed and added Go tests.

    @getvictor
    getvictor committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    dd67455 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Added pe_test.go

    @getvictor
    getvictor committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    3287a24 View commit details
    Browse the repository at this point in the history

  2. Add software uninstall script property, hydrate with scripts 

    Also hydrate uninstall script content ID when pulling installers when uninstall script contents aren't requested
    @iansltx @getvictor
    iansltx authored and getvictor committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    aad34f8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into 20320-feat-uninstall-packages 

    # Conflicts:
#	server/datastore/mysql/schema.sql
#	server/fleet/software_installer.go
    @getvictor
    getvictor committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    cb537db View commit details
    Browse the repository at this point in the history

  4. Updated schema.sql after merge.

    @getvictor
    getvictor committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    bcd30c0 View commit details
    Browse the repository at this point in the history

  5. Fix TestExtractInstallerMetadata test fail.

    @getvictor
    getvictor committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    1cf6cab View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. install API change, integration test and bug fixes.

    @getvictor
    getvictor committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b4b3a8e View commit details
    Browse the repository at this point in the history

  2. Fixed software install API endpoint in tests.

    @getvictor
    getvictor committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a429089 View commit details
    Browse the repository at this point in the history

  3. Final API changes and test updates.

    @getvictor
    getvictor committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c39a3fe View commit details
    Browse the repository at this point in the history

  4. Added migration test.

    @getvictor
    getvictor committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    dea2722 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Updated/tested uninstall scripts, except for EXE.

    @getvictor
    getvictor committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    93f12d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Merge remote-tracking branch 'origin/main' into 20320-feat-uninstall-… 

    …packages
    @getvictor
    getvictor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5f846c8 View commit details
    Browse the repository at this point in the history

  2. Fixed regex.

    @getvictor
    getvictor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    50886eb View commit details
    Browse the repository at this point in the history

  3. Added created_at to fleet/scripts/results and switched to enum for in… 

    …stall status. (#22019)
    @getvictor
    getvictor authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    174b4ec View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Fixes from BE code review.

    @getvictor
    getvictor committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f5fb6ba View commit details
    Browse the repository at this point in the history

  2. UI – Uninstall features for host details, install/uninstall actions, … 

    …activity feed, misc other items (#21933)

## #21566 - Host details updates for Uninstall packages

details > software page. Full tasks outlined in the issue, [Figma
here](https://www.figma.com/design/ToQaK2yUJwDyzagTdrbOfX/%2320320-Uninstall-packages?node-id=5364-13173&m=dev)

**Updated install status tooltips:**

![install-status-tooltips](https://github.com/user-attachments/assets/9869c7d6-f953-4adc-9692-52f5dad9d81a)

**Uninstall action:**

![uninstall-action](https://github.com/user-attachments/assets/189d5755-556c-48ca-8824-08db14ec95d4)

**Update install details:**
![Screenshot 2024-09-09 at 1 12
58 PM](https://github.com/user-attachments/assets/f52b349b-9f01-49d4-b952-6efd60f29979)


## #21931 - updated specs for install/uninstall states

## #21568 - activity feed items for Uninstall
![Screenshot 2024-09-09 at 5 00
07 PM](https://github.com/user-attachments/assets/eb61949a-9f8d-4b9e-a437-2d31a6808f07)
![Screenshot 2024-09-09 at 5 42
52 PM](https://github.com/user-attachments/assets/a8c2de0e-27e3-4d2b-bf69-702ea7b72e48)
![Screenshot 2024-09-09 at 5 43
03 PM](https://github.com/user-attachments/assets/b6127ed3-6fcf-439e-aa3d-91038a025d92)

## #21567 - Uninstall details modal
![Screenshot 2024-09-10 at 7 42
18 PM](https://github.com/user-attachments/assets/a42e4e4a-eadd-4e75-84c5-c5f6a6230950)
_remaining TODO_:
  - [x] manually QA 'failed' states
- [x] determine where to source timestamp from for uninstall activities

- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
Co-authored-by: Victor Lyuboslavsky <victor@fleetdm.com>
    @jacobshandling @getvictor
    3 people authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d9f7935 View commit details
    Browse the repository at this point in the history