-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fleet UI: Fix bug hiding manage automations dropdown from maintainers #23808
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23808 +/- ##
==========================================
- Coverage 63.52% 63.52% -0.01%
==========================================
Files 1592 1594 +2
Lines 151143 151270 +127
Branches 3883 3922 +39
==========================================
+ Hits 96011 96091 +80
- Misses 47480 47523 +43
- Partials 7652 7656 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…aintainer headers for calendar events modal
7f5e8af
to
61b09f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good but I think the future we should look at pulling some of this code into a helpers file. Think it would help reduce the size of this component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice tests!
Issue
Cerra #23448
Description
Screenshot
Global maintainer looking at all teams:
Global/team maintainer looking at team with disabled calendar events
Global/team maintainer viewing calendar events modal
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.