Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Fix bug hiding manage automations dropdown from maintainers #23808

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Nov 14, 2024

Issue

Cerra #23448

Description

  • Show manage automations dropdown to maintainers including options available for them only (run script, install software)

Screenshot

Global maintainer looking at all teams:
Screenshot 2024-12-09 at 1 09 41 PM
Global/team maintainer looking at team with disabled calendar events
Screenshot 2024-12-09 at 12 55 13 PM
Global/team maintainer viewing calendar events modal
Screenshot 2024-12-09 at 12 47 18 PM

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Added/updated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.52%. Comparing base (c06a6b0) to head (8023e86).
Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
...onents/CalendarEventsModal/CalendarEventsModal.tsx 80.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23808      +/-   ##
==========================================
- Coverage   63.52%   63.52%   -0.01%     
==========================================
  Files        1592     1594       +2     
  Lines      151143   151270     +127     
  Branches     3883     3922      +39     
==========================================
+ Hits        96011    96091      +80     
- Misses      47480    47523      +43     
- Partials     7652     7656       +4     
Flag Coverage Δ
frontend 53.76% <80.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RachelElysia RachelElysia marked this pull request as ready for review December 10, 2024 14:45
@RachelElysia RachelElysia requested a review from a team as a code owner December 10, 2024 14:45
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but I think the future we should look at pulling some of this code into a helpers file. Think it would help reduce the size of this component

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tests!

@RachelElysia RachelElysia merged commit 7ecd6d9 into main Dec 11, 2024
14 checks passed
@RachelElysia RachelElysia deleted the 23448-maintainer-automations branch December 11, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants