Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs around new label(s) validation #24049

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

ksykulev
Copy link
Contributor

@ksykulev ksykulev commented Nov 21, 2024

As of #23834 specifying invalid label(s) raises an error. Modified docs to ensure this is clear. Specified in fleetctl query command usage that labels target hosts with "any of" the labels.

#23880

Here is what the fleetctl query help output looks like:
Screenshot 2024-11-21 at 4 43 50 PM

@ksykulev ksykulev force-pushed the 23880-docs-for-labels branch from 0227cba to e8d5e7f Compare November 21, 2024 22:48
@ksykulev ksykulev changed the title Updating docs around new label(s) validation Updated docs around new label(s) validation Nov 21, 2024
@ksykulev ksykulev marked this pull request as ready for review November 21, 2024 22:50
@ksykulev ksykulev requested review from rachaelshaw and a team as code owners November 21, 2024 22:50
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (docs-v4.61.0@0e22a7c). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             docs-v4.61.0   #24049   +/-   ##
===============================================
  Coverage                ?   63.16%           
===============================================
  Files                   ?     1560           
  Lines                   ?   148506           
  Branches                ?     3736           
===============================================
  Hits                    ?    93802           
  Misses                  ?    47299           
  Partials                ?     7405           
Flag Coverage Δ
backend 64.01% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@mostlikelee mostlikelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

As of #23834 specifying invalid
label(s) raises an error. Modified docs to ensure this is clear.
Specified in `fleetctl query` command usage that labels target hosts
with "any of" the labels.
@ksykulev ksykulev force-pushed the 23880-docs-for-labels branch from 9a0b9a1 to 3cbf71d Compare December 2, 2024 17:51
@ksykulev ksykulev added the :improve documentation Involves writing improvements or additions to documentation label Dec 3, 2024
@ksykulev ksykulev merged commit 285ea1e into docs-v4.61.0 Dec 5, 2024
18 of 20 checks passed
@ksykulev ksykulev deleted the 23880-docs-for-labels branch December 5, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:improve documentation Involves writing improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

3 participants