Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop hiding Windows MDM WSTEP config flags #24289

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Stop hiding Windows MDM WSTEP config flags #24289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63fdcca
Stop hiding Windows MDM WSTEP config flags
dantecatalfamo Dec 2, 2024
4b66eda
Add changes/
dantecatalfamo Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/23462-show-windows-mdm-wstep-options
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Display Windows MDM WSTEP flags in `fleet --help`.
13 changes: 0 additions & 13 deletions server/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,19 +1316,6 @@ func (man Manager) addConfigs() {
"calendar.periodicity", 0,
"How much time to wait between processing calendar integration.",
)

// Hide Microsoft/Windows MDM flags as we don't want it to be discoverable for users for now
betaMDMFlags := []string{
"mdm.windows_wstep_identity_cert",
"mdm.windows_wstep_identity_key",
"mdm.windows_wstep_identity_cert_bytes",
"mdm.windows_wstep_identity_key_bytes",
}
for _, mdmFlag := range betaMDMFlags {
if flag := man.command.PersistentFlags().Lookup(flagNameFromConfigKey(mdmFlag)); flag != nil {
flag.Hidden = true
}
}
}

func (man Manager) hideConfig(name string) {
Expand Down
Loading