feat: create automatic install policies for fleet-maintained apps #24298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relates to #23136 This is the UI for the creating of policies when adding fleet maintained software. This includes only the creating of the policy and there will be another PR for viewing more information on the software titles details page. **new install type options. this determines if a policy should be created or not.**  there are also some new icons for the software titles. - [] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. - [x] Manual QA for all new/changed functionality
relates to #23137, #23136 implements to the rest of the UI for automatically creating fleet policies when adding a fleet maintained app. Also includes the API changes needed for this which include changing the `GET /software/titles` and `GET /software/titles/:id` endpoints to include the `automatic_install_policies` data. UI added includes: **Adding tag for automatic install software titles**  **Adding modal to show the policies associated with that software title**  - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jahziel Villasana-Espinoza <jahziel@fleetdm.com>
# Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Added/updated tests - [x] Manual QA for all new/changed functionality
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24298 +/- ##
=======================================
Coverage 63.43% 63.43%
=======================================
Files 1584 1586 +2
Lines 150498 150587 +89
Branches 3771 3831 +60
=======================================
+ Hits 95465 95531 +66
- Misses 47415 47435 +20
- Partials 7618 7621 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gillespi314
previously approved these changes
Dec 3, 2024
gillespi314
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)