Cherry-Pick: Optimized software versions endpoint #24573
Conversation
The software versions endpoint cve details can be truncated using the `without_vulnerability_details` flag. #23679 # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Ian Littman <iansltx@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc-minor-fleet-v4.61.0 #24573 +/- ##
=========================================================
Coverage ? 63.56%
=========================================================
Files ? 1591
Lines ? 150969
Branches ? 3883
=========================================================
Hits ? 95958
Misses ? 47363
Partials ? 7648
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@ksykulev can you please reference the associated PR to |
|
Or connect them |
| @@ -125,6 +125,7 @@ const SoftwareTitles = ({ | |||
| teamId, | |||
| addedSoftwareToken, | |||
| ...vulnFilters, | |||
| ...(showVersions ? { without_vulnerability_details: true } : {}), | |||
There was a problem hiding this comment.
Not blocking (I see this is the cherry pick to RC) but out of curiosity – why not something like withoutVulnDetails: showVersions ?
There was a problem hiding this comment.
I was hoping to exclude the entire query string parameter when it is not needed.
There was a problem hiding this comment.
Oh nice, right. Didn't read below to see that this is referencing the query key directly for the service method arguments.
There was a problem hiding this comment.
Sorry I probably should have gotten a ✅ from someone on front end on the original PR before merging. I will make sure to do that next time there are any react changes.
There was a problem hiding this comment.
Actually now that we're on the subject..withoutVulnerabilityDetails: true would be better, since getSoftwareVersions uses convertParamsToSnakeCase to process all of these field names accordingly anyway.
There was a problem hiding this comment.
Just to keep me honest here:
convertParamsToSnakeCase does indeed working properly with already snake cased keys.
#23679
Original PR: #24496