Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSVL: implement gitops support for labels include/exclude on software packages #24663

Merged
merged 20 commits into from
Dec 17, 2024

Conversation

mna
Copy link
Member

@mna mna commented Dec 11, 2024

#24554

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 83.20611% with 22 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat-labels-scoped-software@fa2c399). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/datastore/mysql/software_installers.go 82.05% 14 Missing and 7 partials ⚠️
server/service/software_installers.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##             feat-labels-scoped-software   #24663   +/-   ##
==============================================================
  Coverage                               ?   63.61%           
==============================================================
  Files                                  ?     1603           
  Lines                                  ?   152247           
  Branches                               ?     3913           
==============================================================
  Hits                                   ?    96845           
  Misses                                 ?    47695           
  Partials                               ?     7707           
Flag Coverage Δ
backend 64.41% <83.20%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mna mna force-pushed the mna-24554-ssvl-gitops branch from 0e535e3 to fcce735 Compare December 16, 2024 13:46
Copy link
Member Author

@mna mna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a big diff but a good chunk is just test yaml files being created for the gitops tests.

@mna mna marked this pull request as ready for review December 17, 2024 17:19
@mna mna requested a review from a team as a code owner December 17, 2024 17:19
Copy link
Contributor

@gillespi314 gillespi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the great tests!

@mna mna merged commit 79ac8fa into feat-labels-scoped-software Dec 17, 2024
18 checks passed
@mna mna deleted the mna-24554-ssvl-gitops branch December 17, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants