[Server config] Speed up bootstrap package delivery w/ CloudFront #24702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-lisica
requested review from
rachaelshaw and
noahtalerman
as code owners
marko-lisica
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
marko-lisica
changed the title
17 tasks
marko-lisica
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
marko-lisica
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
rachaelshaw
requested changes
Dec 13, 2024
Co-authored-by: Rachael Shaw <r@rachael.wtf>
Co-authored-by: Rachael Shaw <r@rachael.wtf>
Co-authored-by: Rachael Shaw <r@rachael.wtf>
marko-lisica
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
rachaelshaw
approved these changes
Dec 16, 2024
marko-lisica
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
marko-lisica
commented
Dec 16, 2024
There was a problem hiding this comment.
Dev note:
-
If user configure
s3_software_installers_cloudfront_url_signing_public_key_idors3_software_installers_cloudfront_url_signing_private_keywithout previously configurings3_software_installers_cloudfront_url, show error:Error: Couldn't configure. "s3_software_installers_cloudfront_url" must be set to use `s3_software_installers_cloudfront_url_signing_public_key_id` and `s3_software_installers_cloudfront_url_signing_private_key`. -
If user configure
s3_software_installers_cloudfront_urland one ofs3_software_installers_cloudfront_url_signing_public_key_idands3_software_installers_cloudfront_url_signing_private_key, show error:Error: Couldn't configure. Both `s3_software_installers_cloudfront_url_signing_public_key_id` and `s3_software_installers_cloudfront_url_signing_private_key` must be set for URL signing.
There was a problem hiding this comment.
If user configure s3_software_installers_cloudfront_url only, show error:
Error: Couldn't configure. Both `s3_software_installers_cloudfront_url_signing_public_key_id` and `s3_software_installers_cloudfront_url_signing_private_key` must be set when CloudFront distribution URL is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #23823