Fixed bug when using without_vulnerability_details and vulnerability filters
#24769
Conversation
ksykulev
force-pushed
the
24765-version-bugfix
branch
from
a0c0683 to
4a88f50
Compare
ksykulev
force-pushed
the
24765-version-bugfix
branch
from
4a88f50 to
3e75532
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24769 +/- ##
==========================================
+ Coverage 54.28% 63.57% +9.29%
==========================================
Files 1601 1601
Lines 151676 151716 +40
Branches 3952 3952
==========================================
+ Hits 82334 96451 +14117
+ Misses 62544 47591 -14953
- Partials 6798 7674 +876
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ksykulev
force-pushed
the
24765-version-bugfix
branch
from
3e75532 to
50b0df4
Compare
| @@ -0,0 +1 @@ | |||
| * Fixed bug when using the `without_vulnerability_details` param along with vulnerability filters in fleet premium. | |||
There was a problem hiding this comment.
We don't do changes files for unreleased bugs
| @@ -917,7 +917,7 @@ func listSoftwareDB( | |||
| DetailsLink: fmt.Sprintf("https://nvd.nist.gov/vuln/detail/%s", cveID), | |||
| CreatedAt: *result.CreatedAt, | |||
| } | |||
| if opts.IncludeCVEScores { | |||
| if opts.IncludeCVEScores && !opts.WithoutVulnerabilityDetails { | |||
There was a problem hiding this comment.
Do we need !without here still?
There was a problem hiding this comment.
Unfortunately we do, because when we are filtering with a vulnerability opts.IncludeCVEScores will be true, and the json response will be large. However, if we put !opts.WithoutVulnerabilityDetails, it will add all the joins, but the json it has to serialize will still be the smaller version.
There was a problem hiding this comment.
Got it; thx for the clarification!
…y filters (#24769) #24765 # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Added/updated tests
#24765
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.