Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap JetBrains EAP versions for maxed last major release for vuln check purposes #24783

Merged
merged 7 commits into from
Dec 16, 2024

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Dec 14, 2024

For #22723.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 63.56%. Comparing base (dc0dddf) to head (bef509a).

Files with missing lines Patch % Lines
server/service/osquery_utils/queries.go 74.19% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24783      +/-   ##
==========================================
+ Coverage   54.28%   63.56%   +9.27%     
==========================================
  Files        1601     1601              
  Lines      151716   151725       +9     
  Branches     3952     3952              
==========================================
+ Hits        82365    96448   +14083     
+ Misses      62549    47600   -14949     
- Partials     6802     7677     +875     
Flag Coverage Δ
backend 64.36% <74.19%> (+10.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mostlikelee mostlikelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we still want to move these "sanitations" to the vulnerability cron? probably need some product input in that case.

@iansltx
Copy link
Member Author

iansltx commented Dec 16, 2024

LGTM. Do we still want to move these "sanitations" to the vulnerability cron? probably need some product input in that case.

IMO yes. Added #24784 to track this.

@iansltx iansltx merged commit 57e979f into main Dec 16, 2024
25 checks passed
@iansltx iansltx deleted the 22723-intellij-eap-versions branch December 16, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants