Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated title description meta tag on layout.ejs #7181

Merged
merged 6 commits into from
Aug 25, 2022

Conversation

mike-j-thomas
Copy link
Member

@mike-j-thomas mike-j-thomas commented Aug 12, 2022

  • updated description meta tag to:

"Fleet is the lightweight, programmable telemetry platform for servers and workstations. Get comprehensive, customizable data from all your devices and operating systems — without the downtime risk."

- updated description meta tag to:

"Fleet is the lightweight, programmable telemetry platform for servers and workstations. Get comprehensive, customizable data from all your devices and operating systems — without the downtime risk"
- updated page title meta tag.
@mike-j-thomas mike-j-thomas temporarily deployed to Docker Hub August 12, 2022 03:57 Inactive
@mike-j-thomas mike-j-thomas changed the title updated description meta tag updated title description meta tag on layout.ejs Aug 12, 2022
@mike-j-thomas mike-j-thomas marked this pull request as ready for review August 12, 2022 03:58
@mike-j-thomas mike-j-thomas requested a review from eashaw as a code owner August 12, 2022 03:58
website/views/layouts/layout.ejs Outdated Show resolved Hide resolved
Changed "downtime risk" to "performance hit" to align with homepage hero message.
@chris-mcgillicuddy chris-mcgillicuddy temporarily deployed to Docker Hub August 12, 2022 16:59 Inactive
@chris-mcgillicuddy
Copy link
Contributor

@mikermcneil, I updated the PR. @eashaw, can you please review it?

@eashaw eashaw temporarily deployed to Docker Hub August 12, 2022 17:43 Inactive
eashaw
eashaw previously approved these changes Aug 12, 2022
Copy link
Contributor

@eashaw eashaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris-mcgillicuddy Looks good! I updated the meta description and title on our other layouts and our Twitter meta tags.

@mike-j-thomas @mikermcneil Should we update the pageTitleForMeta values in routes.js to be [Page title] | Fleet Device Management? (They are currently [Page title] | Fleet for osquery)

@mikermcneil
Copy link
Member

mikermcneil commented Aug 12, 2022

@eashaw I think it's fine as is

But could go either way. It's probably good to be consistent. Up to you. If @chris-mcgillicuddy wants to change it, he can.

- changed to "Fleet for osquery" to "Fleet Device Management"
@mike-j-thomas mike-j-thomas temporarily deployed to Docker Hub August 24, 2022 23:51 Inactive
@mike-j-thomas mike-j-thomas dismissed mikermcneil’s stale review August 24, 2022 23:56

Feedback actioned, and used consistent messaging in routes.js

@mike-j-thomas mike-j-thomas temporarily deployed to Docker Hub August 24, 2022 23:58 Inactive
@mike-j-thomas mike-j-thomas requested a review from eashaw August 24, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants