Frontend: Unit tests /components directory, convert to svg icons #8716
Conversation
RachelElysia
force-pushed
the
unit-tests-low-hanging
branch
from
5364946 to
218f716
Compare
…l and platform cell tests
RachelElysia
force-pushed
the
unit-tests-low-hanging
branch
from
218f716 to
466e04c
Compare
|
nice. we should be able to close some of these issues here when we merge this in. #8773 |
|
🔥 |
|
|
||
| // Click eye icon | ||
| const eyeIcon = screen.findByTestId("eye-icon"); | ||
| await user.click(await eyeIcon); |
There was a problem hiding this comment.
do you need the await in await eyeIcon?
would this work?
const eyeIcon = screen.getByTestId("eye-icon");There was a problem hiding this comment.
Thank you! I was wondering why it wasn't working, merp, the diff between find by test id and get by test id.
|
|
||
| describe("Issue cell", () => { | ||
| it("renders icon, total issues, and failing policies tooltip", async () => { | ||
| const { user } = renderWithSetup( |
There was a problem hiding this comment.
The custom renderer will always set up the user events for testing. what do you think about doing this as an alternative?
const render = customRender()
const { user } = render(...)tbh I kinda prefer just using renderWithSetup when you only need user events setup. what do you think?
There was a problem hiding this comment.
TODO: Rachel, read this later
There was a problem hiding this comment.
@ghernandez345 looks a lot cleaner, only issue I see is when we need { user } and render is defined already so we can't redefine it so it looks wonky (e.g. RevealButton.tests.tsx)
I went ahead and made this change.
There was a problem hiding this comment.
where do you mean? I dont see where that is the case
|
@ghernandez345 @RachelElysia Would y'all please make sure any tests covered here are closed in the related epic? Feel free to bring them onto the release board if you want. Since they don't need QA, it's not strictly necessary. |
Unit tests added:
Other
import {v4 as uuid } from "uuid";because it was throwing an error with the typescript compiler when running a test on the file. Replaced all 4 instances with with loadashuniqueIdSVG icons added moved to icon PR so this PR can focus soley on unit tests
Checklist for submitter
If some of the following don't apply, delete the relevant line.