Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dismissible #3690

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Fix Dismissible #3690

merged 2 commits into from
Jul 23, 2024

Conversation

ndonkoHenri
Copy link
Contributor

@ndonkoHenri ndonkoHenri commented Jul 22, 2024

Closes #3679

Summary by Sourcery

This pull request fixes the Dismissible component to ensure that dismiss events are handled correctly by passing the entire event object, addressing issue #3679.

  • Bug Fixes:
    • Fixed the Dismissible component to correctly handle dismiss events by passing the entire event object instead of just the event data.

Copy link
Contributor

sourcery-ai bot commented Jul 22, 2024

Reviewer's Guide by Sourcery

This pull request addresses issue #3679 by fixing the Dismissible component in the Flet core SDK. The changes primarily involve adjustments to the event handling mechanism to ensure proper data handling and event propagation.

File-Level Changes

Files Changes
sdk/python/packages/flet-core/src/flet_core/dismissible.py Refactored event handling in the Dismissible component to improve data handling and simplify event object construction.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ndonkoHenri - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

# Conflicts:
#	sdk/python/packages/flet-core/src/flet_core/dismissible.py
@FeodorFitsner FeodorFitsner merged commit ab4f5f0 into main Jul 23, 2024
2 checks passed
@ndonkoHenri ndonkoHenri deleted the fix-dismissible branch July 24, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dismissible bug in v0.23.2
2 participants