-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:ControlState
should be resolved based on user-defined order
#4556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FeodorFitsner
approved these changes
Dec 12, 2024
FeodorFitsner
added a commit
that referenced
this pull request
Dec 13, 2024
* feat: implement `Window.ignore_mouse_events` (#4465) * Update project_dependencies.py (#4459) # `Fixed` when I get no markers key in the version_value variable. ```bash Traceback (most recent call last): File "/opt/hostedtoolcache/Python/3.12.5/x64/bin/flet", line 8, in <module> sys.exit(main()) ^^^^^^ File "/opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/flet/cli.py", line 12, in main flet_cli.cli.main() File "/opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/flet_cli/cli.py", line 89, in main args.handler(args) File "/opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/flet_cli/commands/build.py", line 557, in handle self.package_python_app() File "/opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/flet_cli/commands/build.py", line 1303, in package_python_app toml_dependencies = get_poetry_dependencies( ^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/flet_cli/utils/project_dependencies.py", line 41, in get_poetry_dependencies format_dependency_version(dependency, version) File "/opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/flet_cli/utils/project_dependencies.py", line 21, in format_dependency_version if version_value["markers"]: ~~~~~~~~~~~~~^^^^^^^^^^^ KeyError: 'markers' ``` * Remove `v0.26.0` deprecations (#4479) * delete deprecations on py end * delete deprecations on dart end * fix: `SafeArea` object has no attribute `_SafeArea__minimum` (#4500) * remove minimum from SafeArea * remove deprecated props * Changelog updated * Fix publishing flet-windows.zip to releases * Revert "Merge branch 'main' into feodor/prepare-0-25-2" This reverts commit 32a7343, reversing changes made to 3dc01e1. * Changelog updated * Update changelog. * Changelog updated with cherry-picked bug fixes * fix broken `Map.center_on()` and default animations (#4519) * fix center_on * get default animation duration and curve * fix: Tooltip corruption in `Segment` and `BarChartRod` on `update()` (#4525) * avoid jsonDecoding `Segment` and `BarChartRod` tooltips * avoid jsonEncoding `Segment` and `BarChartRod` tooltips * Unset theme visual density default * Unset `SegmentedButton` border side default * `TextField.hint_text` should be displayed if `label` is not specified * fix: Setting `CheckBox.border_side.stroke_align` to an Enum fails (#4526) * `BorderSideStrokeAlign` should inherit from float * properly parse `Chip.border_side` * fix:`ControlState` should be resolved based on user-defined order (#4556) * ControlState: rename "" to "default" * resolve ControlState on user-defined order * fix failing tests * remove breaking line * fix wrong attribute name (#4557) * Publish flet wheels to GitHub releases * remove redeclared `MapPointerDeviceType` --------- Co-authored-by: TheEthicalBoy <98978078+ndonkoHenri@users.noreply.github.com> Co-authored-by: Osama Mohammed Al-zabidi <57198110+omamkaz@users.noreply.github.com> Co-authored-by: ndonkoHenri <robotcoder4@protonmail.com>
syleishere
pushed a commit
to syleishere/flet-dev
that referenced
this pull request
Dec 14, 2024
…et-dev#4556) * ControlState: rename "" to "default" * resolve ControlState on user-defined order * fix failing tests * remove breaking line
Bbalduzz
added a commit
to Bbalduzz/fluentflet
that referenced
this pull request
Dec 14, 2024
### `TextBox` Component - Added new features: - `prefix` text support - `suffix` text support - Added dynamic padding calculations based on prefix/suffix content - Enhanced focus/blur handling: - Added opacity control for hint text - Improved hint text color management - Added explicit handling for hint text style changes during focus/blur states ### `Button` Component - Reorganized state handling: - Reordered control states for better consistency. Flet version must be > `0.25.2` ([see why](flet-dev/flet#4556)) - State configurations now properly implement: - Hover states - Pressed states - Default states - Disabled states ### Navigation System - Added new `NavigationType` enum with two modes: - `STANDARD`: Original layout that pushes content - `OVERLAY`: Navigation overlays the content - Enhanced navigation panel styling: - Added blur effects for expanded state - Implemented border radius adjustments - Added shadow effects - Improved animation handling ### Window System - Added `NavigationType` to exported symbols - Modified default window behavior to support new navigation types - Enhanced window layout management for both standard and overlay navigation modes ## Infrastructure Changes ### Dependencies - Updated Flet dependency to match the new pypi library structure: - Old: `flet>=0.25.1` - New: `flet[all]>=0.25.2` ## API Changes and Deprecations - Removed **deprecated** `right_icon` and `right_action` properties from `TextBox` - Changed method of handling icon actions in TextBox to new action system - Modified window navigation behavior to support new navigation types ## Performance Improvements - Implemented icon availability caching in icon browser - Added pre-calculated styles for common UI elements - Optimized update patterns in components to reduce unnecessary rerenders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4409
Test Code
Summary by Sourcery
Resolve
ControlState
based on user-defined order and replace the empty string with 'default' for default state handling.Bug Fixes:
ControlState
to respect user-defined order, ensuring that the correct state is applied based on the specified sequence.Enhancements:
Tests: