FIX: Final touches patches for pre-release #1346
Conversation
daquinteroflex
force-pushed
the
dario/patches_pre_26_release
branch
4 times, most recently
from
d45d7df
to
9be1004
Compare
daquinteroflex
force-pushed
the
dario/patches_pre_26_release
branch
from
9be1004
to
529b7b4
Compare
There was a problem hiding this comment.
Looks good, @daquinteroflex , thank you!
I had a few minor comments / slight improvements to go over, but overall looks good and I'm approving so we can merge once they are all addressed.
| ] | ||
| jax = [ | ||
| {version = ">=0.4.1,<=0.4.14", extras = ["cpu"], platform = "linux", source="jaxsource", optional = true}, | ||
| {version = ">=0.4.1,<=0.4.14", extras = ["cpu"], platform = "darwin", source="jaxsource", optional = true}, | ||
| {version = ">=0.4.13,<=0.4.14", extras = ["cpu"], platform = "win32", source="jaxsource", optional = true} | ||
| {version = ">=0.4.13,<=0.4.14", extras = ["cpu"], platform = "win32", python = "^3.9", source="jaxsource", optional = true} |
There was a problem hiding this comment.
we're already excluding any windows < 3.9 now? so maybe we dont need this python condition anymore?
There was a problem hiding this comment.
So I think we're excluding it out of tests, I thought we were still supporting 3.8 where this would have to be included in the packaging?
There was a problem hiding this comment.
hm, I thought we were excluding windows with python 3.8 because jax didn't work at all? or was it just that we couldn't install it in our automatic test? feel free to keep it how you had it, maybe I just misunderstood
There was a problem hiding this comment.
I think it was because it was badly packaged for win py3.8. So I think the condition above just excludes that if I've understood the poetry requirements well.
daquinteroflex
force-pushed
the
dario/patches_pre_26_release
branch
4 times, most recently
from
1b86d4f
to
81aa5b7
Compare
|
I think all tests are passing so let me know if you want a final look as I had to sort out some things with the fixes or if just going ahead! |
momchil-flex
force-pushed
the
dario/patches_pre_26_release
branch
from
81aa5b7
to
5b9519e
Compare
momchil-flex
force-pushed
the
dario/patches_pre_26_release
branch
from
5b9519e
to
53a436b
Compare
(Maybe on this PR) lazy importsFundamentally needs PR on pre/2.5 and post propagated to 2.6