Allow importing specific field from vtk #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
reviewed
Jan 24, 2024
tests/test_data/test_datasets.py
Outdated
| @@ -352,6 +374,14 @@ def test_tetrahedral_dataset(tmp_path, ds_name): | |||
| assert np.all(tet_grid._vtk_offsets == np.array([0, 4, 8])) | |||
| assert tet_grid.name == ds_name | |||
|
|
|||
| # since vtk is attempted to be imported during a dependent function call | |||
| # let's call one of those so that vtk dict is properly populated | |||
| try: | |||
There was a problem hiding this comment.
what is the reason behind using a try / except here? (when would vtk not be imported in the test?) maybe it could make sense to make this a pytest.mark.parameterized() where we run the function once with vtk and once without? maybe I'm just a bit confused about what this block of code is doing here.
There was a problem hiding this comment.
Revised this a bit. So, currently it works the following way:
- This test is designed to work for both when
vtkis present and when it is not. - Which branch to check is determined by parameter
no_vtk. - I tried using
pytest.mark.parameterized()to conveniently test both cases, but I couldn't make it work. it seems to be tricky to properly unload already loaded module. So, instead I just re-run the same tests in a separate pytest call here with a monkeypatch to skip loadingvtkandno_vtk=True
There was a problem hiding this comment.
I see, I think the new implementation is fine.
btw I ran into something similar with wanting to test adjoint with and without jax installed, here's what I came up with in the end.
(I guess I also didn't use parameterize, maybe for similar reasons)
tylerflex
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small PR that came out of working on the charge example flexcompute/tidy3d-notebooks#25 and it does two things:
.vtufiles with specific names if such files contain multiple fields (e.g. "Electrons", "Holes", etc)PerturbationMediumwithCustomChargePerturbation/CustomHeatPerturbation