Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pec freq arg #1502

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix pec freq arg #1502

merged 1 commit into from
Feb 27, 2024

Conversation

dmarek-flex
Copy link
Contributor

Small bug when trying to plot epsilon with coord_key not equals to centers and freq=None. Other media assume an infinite frequency but PEC results in TypeError at multiplication

eps_sample = sim.epsilon(box=box, coord_key="Ex")

@dmarek-flex dmarek-flex marked this pull request as ready for review February 26, 2024 21:50
@dmarek-flex dmarek-flex added the Bug something isnt working label Feb 26, 2024
@dmarek-flex dmarek-flex self-assigned this Feb 26, 2024
@tylerflex
Copy link
Collaborator

Thanks @dmarek-flex, appreciate you submitting the fix along with the bug report.

Maybe let's try to merge this into develop just to get it out faster.
Also, can you add a line to the CHANGELOG.md under ### fixed?

Thanks!

@weiliangjin2021
Copy link
Collaborator

I wonder why not add the decorator @ensure_freq_in_range as in other materials?

@weiliangjin2021
Copy link
Collaborator

Maybe let's try to merge this into develop just to get it out faster. Also, can you add a line to the CHANGELOG.md under ### fixed?

If merged to develop, we'll need to merge develop to pre/2.7 since the development for RF is on pre/2.7 branch?

@tylerflex
Copy link
Collaborator

we could also just apply this commit to both branches potentially. Or it's ok if we keep merging this into pre/2.7 for simplicity.

@dmarek-flex
Copy link
Contributor Author

I wonder why not add the decorator @ensure_freq_in_range as in other materials?

Yes, I can do that and it would fix it as well.

@weiliangjin2021 weiliangjin2021 changed the base branch from pre/2.7 to develop February 27, 2024 19:03
@weiliangjin2021 weiliangjin2021 changed the base branch from develop to pre/2.7 February 27, 2024 19:05
@weiliangjin2021 weiliangjin2021 changed the base branch from pre/2.7 to develop February 27, 2024 19:05
@weiliangjin2021 weiliangjin2021 merged commit ea22632 into develop Feb 27, 2024
13 checks passed
@weiliangjin2021 weiliangjin2021 deleted the dmarek/fix-pec-freq-arg branch February 27, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug something isnt working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants