fix logger assignment in web core #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbochkov-flexcompute
requested review from
lucas-flexcompute and
tomflexcompute
tomflexcompute
approved these changes
Mar 27, 2024
lucas-flexcompute
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From documentation of
logging.basicConfig()it looks like it gets automatically invoked wheneverloggingis used first time in the code. After that callinglogging.basicConfig()will not have effect unless flagforce=Trueis used.Apparently, in our
web.corecode we substituteloggingwith tidy3d'sloga bit too late, some of imports already call it. Rearranging order of imports and logger assignment resolves the issue.