Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smatrix backwards compatible import #1595

Merged
merged 1 commit into from
Apr 10, 2024
Merged

smatrix backwards compatible import #1595

merged 1 commit into from
Apr 10, 2024

Conversation

tylerflex
Copy link
Collaborator

@tylerflex tylerflex commented Apr 10, 2024 •
edited
Loading

smatrix notebooks had

from tidy3d.plugins.smatrix.smatrix import Port

this makes that still possible for backwards compatibility.

@tylerflex tylerflex changed the base branch from develop to pre/2.7 April 10, 2024 07:11
@tylerflex tylerflex force-pushed the tyler/smatrix/backwards_compatible_import branch from 9a7977e to 6cc9f38 Compare April 10, 2024 07:12
@tylerflex tylerflex added the 2.7 will go into version 2.7.* label Apr 10, 2024
dmarek-flex
dmarek-flex approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@dmarek-flex dmarek-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@momchil-flex momchil-flex merged commit f23abb5 into pre/2.7 Apr 10, 2024
12 of 13 checks passed
@momchil-flex momchil-flex deleted the tyler/smatrix/backwards_compatible_import branch April 10, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmarek-flex dmarek-flex dmarek-flex approved these changes

Assignees
No one assigned
Labels
2.7 will go into version 2.7.*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tylerflex @dmarek-flex @momchil-flex