📦 BUILD: Python 3.12 compatibility #1622
Conversation
daquinteroflex
force-pushed
the
dario/python_3_12
branch
3 times, most recently
from
5d6bdfa
to
d33814b
Compare
|
So the only remaining issue is mac with python 3.12 and gdstk? Probably @lucas-flexcompute needs to build a new wheel or something? |
|
I did not notice macOS was missing python 3.11 and 3.12! I think it's just a matter of updating the GH actions for CIBW. I'm checking now: https://github.com/heitzmann/gdstk/actions/runs/8730179893 |
|
The 3.12 versions are now on PyPI. |
momchil-flex
force-pushed
the
dario/python_3_12
branch
from
ad054a0
to
acc11d8
Compare
|
Seems like now xarray errors... |
daquinteroflex
force-pushed
the
dario/python_3_12
branch
from
2ae753c
to
0288112
Compare
daquinteroflex
changed the title
|
Thanks both for your help and advice! Think it's passing now and seems reasonable imo. However, maybe we want to merge #1593 before this one as it depends on those updates too. |
| sax = {version="*", optional = true} | ||
| vtk = {version="<=9.2.6", optional = true} | ||
| vtk = {version=">=9.2.6", optional = true} |
There was a problem hiding this comment.
Similarly, are you sure about this? @dbochkov any thoughts?
There was a problem hiding this comment.
Should be ok starting with 2.7
tests/test_timing/import_tidy3d.py
Outdated
| # subprocess.call(["python", "-c", "pass"]) | ||
| # python_load_time += time.time() - s | ||
| # | ||
| # print(f"average tidy3d load time = {(tidy3d_load_time - python_load_time) / n}") |
There was a problem hiding this comment.
Whoops that was temporary to speed up testing, but now have brought it back.
momchil-flex
force-pushed
the
dario/python_3_12
branch
from
0288112
to
acc11d8
Compare
|
AHHH the dangers of force pushing!!! Yesterday I had done I assume you have a copy locally so hopefully no big deal... Sorry! |
daquinteroflex
force-pushed
the
dario/python_3_12
branch
from
acc11d8
to
9d3f10f
Compare
|
No worries haha! All feedback implemented. I'm ok if we want to add it to rc1. I believe the main doubt were the jax upgrade questions @tylerflex fyi |
|
Well, better to get feedback right away than when we do the official release :) |
daquinteroflex
force-pushed
the
dario/python_3_12
branch
2 times, most recently
from
b6ccdda
to
4f28a5b
Compare
daquinteroflex
force-pushed
the
dario/python_3_12
branch
from
4f28a5b
to
d55e474
Compare
Related to:
#1620
#1317
#1593