validate single pixel mode source #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarek-flex
force-pushed
the
dmarek/val-single-pixel-mode-source
branch
2 times, most recently
from
2dbb0ab
to
0c8abfd
Compare
dmarek-flex
force-pushed
the
dmarek/val-single-pixel-mode-source
branch
from
0c8abfd
to
a3e3504
Compare
tylerflex
approved these changes
May 3, 2024
There was a problem hiding this comment.
Looks good, just a pretty minor comment in the validator. thanks @dmarek-flex for taking care of this so quickly!
dmarek-flex
force-pushed
the
dmarek/val-single-pixel-mode-source
branch
2 times, most recently
from
027db4f
to
90d09ba
Compare
momchil-flex
approved these changes
May 3, 2024
dmarek-flex
force-pushed
the
dmarek/val-single-pixel-mode-source
branch
from
90d09ba
to
4d7f723
Compare
dmarek-flex
force-pushed
the
dmarek/val-single-pixel-mode-source
branch
from
4d7f723
to
52a1bbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate that mode sources have at least 3 cells (even with size 0 it is possible to pick up 2 cells, so I chose 2 as the limit).
Also included are some changes to make ruff happy and fix some other tests that were affected by this new validation step.