Update CONTRIBUTING.md post-repo-split #1564
Conversation
…dir to avoid confusion
lockshaw
requested review from
reyna-abhyankar,
Marsella8,
eric-zheng and
victorli2002
lockshaw
changed the title
There was a problem hiding this comment.
Reviewed 47 of 453 files at r1, all commit messages.
Reviewable status: 47 of 453 files reviewed, 1 unresolved discussion (waiting on @eric-zheng, @lockshaw, and @Marsella8)
CONTRIBUTING.md line 15 at r2 (raw file):
2. If you don't have root permissions: [DavHau/nix-portable](https://github.com/DavHau/nix-portable). Note that nix-portable does not work particularly well if the nix store is in NFS, so if you are running on an
It might be helpful to say what NFS is (idk what it is).
There was a problem hiding this comment.
Reviewable status: 47 of 453 files reviewed, 2 unresolved discussions (waiting on @eric-zheng and @lockshaw)
CONTRIBUTING.md line 59 at r2 (raw file):
(ff) $ proj cmake ... (ff) $ proj test
also add a comment related to running tests without running the GPU tests? I think you mentioned something like that in the last meeting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1564 +/- ##
=======================================
Coverage 60.47% 60.47%
=======================================
Files 606 606
Lines 14723 14723
=======================================
Hits 8903 8903
Misses 5820 5820
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Reviewable status: 46 of 453 files reviewed, 1 unresolved discussion (waiting on @eric-zheng, @Marsella8, and @victorli2002)
CONTRIBUTING.md line 15 at r2 (raw file):
Previously, victorli2002 (Victor Li) wrote…
It might be helpful to say what NFS is (idk what it is).
Done.
CONTRIBUTING.md line 59 at r2 (raw file):
Previously, Marsella8 wrote…
also add a comment related to running tests without running the GPU tests? I think you mentioned something like that in the last meeting
Done.
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 46 of 453 files reviewed, all discussions resolved (waiting on @eric-zheng and @victorli2002)
Description of changes:
Update docs post-repo split, especially the developer/setup docs in CONTRIBUTING.md.
Also aggressively remove a whole bunch of outdated files. Remember that these are all available in the archived master and inference branches, as well as in the git history.
Related Issues:
Linked Issues:
Issues closed by this PR:
This change is