Move travis CI to use xcode 9 instead of 7.3 #266
Conversation
|
This may or may not merge. In trying to alleviate commit problems, I found that AppleClang 9 is working great. So, I'm trying a sampling to see if TravisCI behaves similarly. |
|
Moving to xcode 9 didn't fix the problems with the Inexplicably, I'm running this on another mac with (what appears to be) the same configuration and the failing tests don't fail. I'm unsure why it continues to fail in CI. @jslee02 Let me know if you still approve jumping all the way to XCode 9. |
SeanCurtis-TRI
changed the title
I'm on board using the newer version of macOS. However, if some tests fail on the old version of macOS + Xcode (< Xcode 9 + OS X 10.12), it could be an issue if someone wants to use FCL in that configuration. I'm not sure if that case is considerable, but I think we could revisit this at that time. |
|
I agree. What is the oldest version of XCode fcl wants to support? |
SeanCurtis-TRI
force-pushed
the
PR_advance_travis_ci_OSX
branch
from
a9a34e5 to
aee122a
Compare
|
I don't use macOS actively so it would be better someone else suggests that. 😅 |
|
Homebrew supports and builds binaries (bottles) for the 3 most recent releases (10.11 el capitan, 10.12 sierra, 10.13 high sierra). It's a big pain to support anything older than that. For CI, we just use test on one distro for gazebo, though we make sure that things compile and build on the 3 versions that homebrew supports. |
|
if you set an environment variable |
|
The problem I'm having with CI is not seeing the error details. It is reproducing the errors anywhere outside of travis. Travis is currently configured to report the error logs. But, try as I might, I can't get failures on the mac I have access to. (Hence the iterative changes in this PR with the hope that bringing CI closer to "my" mac, the errors would go away. Such has not proven to be the case.) My problem is that before Friday, I had never touched a mac in my life. So, I know nothing about xcode, bottles, homebrew, or how to interpret osx versions. I'm putting this on the back burner for now..it's clear this is going to be a big, uphill battle for me and I don't have the cycles to spare. Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
How about we support the latest image of each releases? According to this doc, they are:
Also, if we build with debug and release mode for each image, the build matrix size would be too large. So I suggest building with both of debug and release only for the latest (xcode9.4) and building with release for others. By the way, I don't have a strong preference on this. So I'm totally fine with merging this PR as it is. Edit: Oh, you said the failure is persistent with xcode8. I'm open to either (1) not supporting xcode8 or (2) creating an issue (of the failure on xcode8) and considering resolving it later. |
SeanCurtis-TRI
force-pushed
the
PR_advance_travis_ci_OSX
branch
from
db482e5 to
b450b44
Compare
There was a problem hiding this comment.
I went ahead and did some PR cleanup (curated the commits). I'll let it roll through CI and if we're all good, I say we merge and move on with life.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Various mac errors seem to go away by advancing from xcode 7.3 to later versions. This tests it under travis.ci.
This change is